From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107405 invoked by alias); 26 May 2017 07:47:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107384 invoked by uid 89); 26 May 2017 07:47:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1334 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 07:47:03 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dE9xd-0004Ca-1W for gdb-patches@sourceware.org; Fri, 26 May 2017 03:47:05 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dE9xc-0004CU-UH; Fri, 26 May 2017 03:47:00 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3564 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dE9xb-00064X-VY; Fri, 26 May 2017 03:47:00 -0400 Date: Fri, 26 May 2017 07:47:00 -0000 Message-Id: <83tw48jc0f.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org In-reply-to: <15568468-0852-d786-8777-4adbd16825a0@redhat.com> (message from Pedro Alves on Thu, 25 May 2017 11:12:22 +0100) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Reply-to: Eli Zaretskii References: <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> <837f18ohr2.fsf@gnu.org> <54594002-5d70-9ff8-c481-0cbfc8c68c7b@redhat.com> <834lwam7n4.fsf@gnu.org> <20170524193716.5arjibe4s5efvgj7@adacore.com> <15568468-0852-d786-8777-4adbd16825a0@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00552.txt.bz2 > Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org > From: Pedro Alves > Date: Thu, 25 May 2017 11:12:22 +0100 > > This: > > >> + (std::to_string) [REPLACE_TO_STRING]: Provide a replacement > >> + implementation. > > Should really be: > > (gdb::to_string): Define. The code says std::to_string, though. So it sounds like some coding conventions are being applied here of which I wasn't aware, and neither is Emacs. Are these conventions described somewhere? > and you need an entry for the cli/cli-script.c change, like: > > * cli/cli-script.c (user_args::insert_args): Use it. I added that, but once again, the convention to put the fully-qualified symbol name in the log entry should be documented, if it isn't already, because Emacs doesn't do that, at least not by default. Is this convention applied consistently across the project? > > Did we consider the option of perhaps only pushing this patch > > to the 8.0 branch, and require MinGW 5.x for the current master? > > If we did it that way, it would allow us to avoid remembering > > that we need to use gdb::to_string instead of std::to_string. > > That'd be fine with me, FWIW. I wasn't sure what it means "to require MinGW 5.x", in practice, but I pushed only to the branch for now.