From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49677 invoked by alias); 17 Mar 2019 16:05:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49667 invoked by uid 89); 17 Mar 2019 16:05:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=windowwidth, window-width, substance, HX-Languages-Length:552 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 16:05:26 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5YHq-0001Ca-D3; Sun, 17 Mar 2019 12:05:22 -0400 Received: from [176.228.60.248] (port=3403 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5YHp-0006Fe-37; Sun, 17 Mar 2019 12:05:21 -0400 Date: Sun, 17 Mar 2019 16:05:00 -0000 Message-Id: <83tvg1wkp7.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: ssbssa@yahoo.de, tom@tromey.com, gdb-patches@sourceware.org In-reply-to: <6035325c-bb76-fe7f-5688-8c78a8b89a1a@redhat.com> (message from Pedro Alves on Thu, 14 Mar 2019 20:25:25 +0000) Subject: Re: "next" into line longer than the source window-width (Re: [RFC 8.3 0/3] Some style fixes) References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> <87o96g3upj.fsf@tromey.com> <375483967.6114402.1552410513314@mail.yahoo.com> <83lg1i3hkj.fsf@gnu.org> <6035325c-bb76-fe7f-5688-8c78a8b89a1a@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00346.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Thu, 14 Mar 2019 20:25:25 +0000 > > The substance of the patch LGTM. > > But all this code above looks very much like the new tui_refill_source_window > function, added today by 6f11e6824e15. I think you can replace all > the above with: > > - tui_refresh_win (&win_info->generic); > + tui_refill_source_window (win_info); You are right; I pushed the above to both branches.