From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mPrkKAHDhV9UCwAAWB0awg (envelope-from ) for ; Tue, 13 Oct 2020 11:08:49 -0400 Received: by simark.ca (Postfix, from userid 112) id A5A811EF6F; Tue, 13 Oct 2020 11:08:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 587971E58E for ; Tue, 13 Oct 2020 11:08:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9EF05383E809; Tue, 13 Oct 2020 15:08:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EF05383E809 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602601728; bh=Rk8wVCgSEZVlnGHV/pVfUhMh1F4rM3QFDQwpzWXLYdc=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ENYAMdy1fnKjqpE5o46CCPqyNinU1A9H8bMs8Hi/UEVzMn2486hOgUppSNftG9LVC o2rQjE9/xpQg35ENbkwiriTL9ymmaFbBdasHzXtRuXFGTLZb6dbM3XexyIy7h5jsKL 9lDf8mMVvTAjO4QXjPTXmiNRlobBu2DEa5NBdezo= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9703D38618EB for ; Tue, 13 Oct 2020 15:08:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9703D38618EB Received: from fencepost.gnu.org ([2001:470:142:3::e]:36995) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLus-0007TO-MT; Tue, 13 Oct 2020 11:08:42 -0400 Received: from [176.228.60.248] (port=4002 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSLus-000173-1S; Tue, 13 Oct 2020 11:08:42 -0400 Date: Tue, 13 Oct 2020 18:08:50 +0300 Message-Id: <83tuuy17ul.fsf@gnu.org> To: Tankut Baris Aktemur In-Reply-To: (message from Tankut Baris Aktemur via Gdb-patches on Tue, 13 Oct 2020 14:25:03 +0200) Subject: Re: [PATCH v4 2/2] gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition References: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: simark@simark.ca, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Date: Tue, 13 Oct 2020 14:25:03 +0200 > From: Tankut Baris Aktemur via Gdb-patches > Cc: simark@simark.ca > > gdb/ChangeLog: > 2020-07-31 Tankut Baris Aktemur > > * breakpoint.h (set_breakpoint_condition): Add a new bool parameter. > * breakpoint.c: Update the help text of the 'condition' and 'break' > commands. > (set_breakpoint_condition): Take a new bool parameter > to control whether condition definition should be forced even when > the condition expression is invalid in all of the current locations. > (condition_command): Update the call to 'set_breakpoint_condition'. > (find_condition_and_thread): Take the "-force-condition" flag into > account. > * linespec.c (linespec_keywords): Add "-force-condition" as an > element. > (FORCE_KEYWORD_INDEX): New #define. > (linespec_lexer_lex_keyword): Update to consider "-force-condition" > as a keyword. > * ada-lang.c (create_ada_exception_catchpoint): Ditto. > * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x): Ditto. > * python/py-breakpoint.c (bppy_set_condition): Ditto. > > gdb/testsuite/ChangeLog: > 2020-08-20 Tankut Baris Aktemur > > * gdb.base/condbreak-multi-context.exp: Expand to test forcing > the condition. > * gdb.linespec/cpcompletion.exp: Update to consider the > '-force-condition' keyword. > * gdb.linespec/explicit.exp: Ditto. > * lib/completion-support.exp: Ditto. > > gdb/doc/ChangeLog: > 2020-07-31 Tankut Baris Aktemur > > * gdb.texinfo (Set Breaks): Document the '-force-condition' flag > of the 'break'command. > * gdb.texinfo (Conditions): Document the '-force' flag of the > 'condition' command. OK for the documentation part. What about the NEWS? Thanks.