Re: [RFAv2] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno.

Philippe Waroquiers via Gdb-patches
2022-06-05T19:10:01Z

Thanks for the (as usual) quick review.
I will send soon an RFAv3 where I have fixed all the below comments.
I also checked the occurrences of 'location' and used (code location' instead.

Some feedback for specific points:

On Sun, 2022-06-05 at 20:10 +0300, Eli Zaretskii wrote:
>
> So how does $bkptno differ from $bpnum?
I have added the following in the manual after the first small example
showing $bkptno:

Note that @samp{$bkptno} and @samp{$bpnum} are not equivalent:
@samp{$bkptno} is set to the breakpoint number @b{last hit}, while
@samp{$bpnum} is set to the breakpoint number @b{last set}.

> > +For a @samp{breakpoint-hit} stopped reason, when the breakpoint
> > +encountered has multiple locations, the field @samp{bkptno} is
> > +followed by the field @samp{locno}.
>
> This is a backward-incompatible change, no? Does it require bumping
> the version of the MI protocol?
The documentation indicates that adding a new field in the mi output
can be done without changing the MI version.
I have indicated the below in the commit log:
Note that according to the GDB user manual node 'GDB/MI Development and Front
Ends', it is ok to add new fields without changing the MI version.

Thanks
Philippe