Re: [RFA] Fix "break foo" when `foo's prologue ends before line table

Eli Zaretskii
2009-05-12T03:13:46Z

> Date: Mon, 11 May 2009 17:20:06 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
>
> > > Do you really want "break foo" to break on the line where a () is
> > > called?
> >
> > It's hard to say, really. There are arguments for both, but I
> > personally tend to think that stopping on the call to `a' is what I'd
> > want.
> >
> > What do others think?
>
> I agree with Pedro.

You mean, with Joel.

Okay, I will go with that approach, then. But do we agree that my
general idea is the way to go, as opposed to fixing the lineinfo table
when it is read from the COFF file?

> > > /* The order of entries in the linetable is significant. They should
> > > be sorted by increasing values of the pc field.
> >
> > Well, granted, I've seen that comment. But (a) are we sure all of our
> > comments are necessarily accurate to rely on them?, and (b) it
> > continues to say
>
> This data structure relies on being sorted by PC. You can see e.g. in
> find_pc_sect_line.

Right.

Do you also agree with Joel that looping on all symtabs is not
necessary, in general, and that using the single symtab given by
SYMBOL_SYMTAB(sym) is enough?