From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67766-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26402 invoked by alias); 17 Oct 2009 16:49:48 -0000
Received: (qmail 26393 invoked by uid 22791); 17 Oct 2009 16:49:46 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Oct 2009 16:49:41 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0KRO00D0040H9C00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 17 Oct 2009 18:49:24 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.117.47]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KRO007A342BJA90@a-mtaout21.012.net.il>; Sat, 17 Oct 2009 18:49:24 +0200 (IST)
Date: Sat, 17 Oct 2009 16:49:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC][patch] Allow to disassemble line.
In-reply-to: <8ac60eac0910170849p45d24187o449011fc0aa21fc7@mail.gmail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83skdige7b.fsf@gnu.org>
References: <20091002004954.8966C76B2B@ppluzhnikov.mtv.corp.google.com> <8ac60eac0910080916i5a2eb49an5f21f3b5c7fb96ef@mail.gmail.com> <20091008162350.GA8625@caradoc.them.org> <8ac60eac0910080952p46f15693x6ed339473db0139d@mail.gmail.com> <8ac60eac0910161607k55fee22cs379c5b7635d7b6a@mail.gmail.com> <8ac60eac0910161611u7056433m8912ce9ac5a83134@mail.gmail.com> <83zl7qh163.fsf@gnu.org> <8ac60eac0910170849p45d24187o449011fc0aa21fc7@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00389.txt.bz2

> Date: Sat, 17 Oct 2009 08:49:48 -0700
> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> Cc: gdb-patches@sourceware.org
> 
> It's the "leading asterisk" that is the marker here, and it moves from
> 0x000000000054d225 to 0x000000000054d229.
> 
> Instruction itself (which is "callq  *%rax") is constant, just like it
> should be.
> 
> Or did I misunderstand your question?

No, you didn't misunderstand.

However, in that case, how about using ">" instead of "*"?  That
should make the indication unambiguous.  If it duped me, it could dupe
someone else.

We should also mention this in the manual, I think (assuming the patch
is approved).

Thanks.