From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5422 invoked by alias); 20 Mar 2013 17:24:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5408 invoked by uid 89); 20 Mar 2013 17:24:21 -0000 X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 20 Mar 2013 17:24:17 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MJY00D00YWH2U00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 20 Mar 2013 19:23:43 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJY00CA2YZJEXD0@a-mtaout20.012.net.il>; Wed, 20 Mar 2013 19:23:43 +0200 (IST) Date: Wed, 20 Mar 2013 17:36:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 3/3] Don't use unportable macros In-reply-to: <51492077.30307@codesourcery.com> To: Yao Qi Cc: dje@google.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83sj3qyogk.fsf@gnu.org> References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-4-git-send-email-yao@codesourcery.com> <51492077.30307@codesourcery.com> X-SW-Source: 2013-03/txt/msg00755.txt.bz2 > Date: Wed, 20 Mar 2013 10:35:35 +0800 > From: Yao Qi > CC: gdb-patches , Eli Zaretskii > > Also define a macro 'mkdir' in this patch, as Eli suggested before. Is > it OK? The macro is OK, but please make sure unistd.h is included by this file, because that's where MinGW defines the prototype of _mkdir.