From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30299 invoked by alias); 11 Apr 2013 17:47:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30202 invoked by uid 89); 11 Apr 2013 17:47:37 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 17:47:35 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0ML300800QORJE00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Thu, 11 Apr 2013 20:47:32 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ML3008BQQR7IC20@a-mtaout21.012.net.il>; Thu, 11 Apr 2013 20:47:32 +0300 (IDT) Date: Thu, 11 Apr 2013 23:00:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 5/7] range stepping: New command 'maint set range stepping' In-reply-to: <1365648222-12540-6-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83sj2x9cxl.fsf@gnu.org> References: <1363006291-13334-1-git-send-email-yao@codesourcery.com> <1365648222-12540-1-git-send-email-yao@codesourcery.com> <1365648222-12540-6-git-send-email-yao@codesourcery.com> X-SW-Source: 2013-04/txt/msg00337.txt.bz2 > From: Yao Qi > Date: Thu, 11 Apr 2013 10:43:40 +0800 > > On 03/18/2013 11:45 AM, Eli Zaretskii wrote: > >> Don't have any special reasons to do this. The range stepping should be > >> >always on if target supports, and it can be turned off for some > >> >"maintenance purpose", so I set this command as a maintenance > >> >command. > > What would be the possible reasons to turn this feature off? > > > > Once we have the reasons, we could try thinking whether or not they > > are limited to GDB maintenance. > > Range-stepping is useful to speed up some operations, so users don't > have to turn it off. The reason turning it off could be that the > remote stub has a bug in supporting range stepping, so we have to > disable it in GDB side. To me, this means that the command is not really a maintenance command. It is a user option, albeit one that is not expected to be used frequently. > I considered to name the command to "set remote range-stepping", but > range-stepping is not specific to remote target, and it can be > implemented on native target as well. So "set remote range-stepping" > is not a good choice. I also considered "set range-stepping", but > unable to find a reasonable place for documentation on it. How about "Continuing and Stepping"? > In V2, I don't update the command name. > +@kindex maint set range-stepping > +@kindex maint show range-stepping > +@cindex range-stepping > +@item maint set range-stepping > +@itemx maint show range-stepping > +@vindex $range_stepping_counter > +Control whether to do stepping in an address range. The debugger convenience > +variable @samp{$range_stepping_counter} contains the number of range stepping > +@value{GDBN} has performed. This is OK, but it doesn't really explain what the setting does. The doc string of the command is much better: > + add_setshow_boolean_cmd ("range-stepping", class_maintenance, > + &use_range_stepping, _("\ > +Enable or disable range-stepping."), _("\ > +Show whether range-stepping is enabled."), _("\ > +If On, GDB will tell the target to do stepping a range of address.\n\ > +This will speed up stepping a line of source file.\n\ > +If off, GDB will not use it, even if such is supported by the \n\ > +target"), Except that "do stepping a range of address" is not really correct. How about this rewording: If On, GDB will instruct the target to single-step through all the instructions in a range of addresses, and report back only once at the end. This reduces the amount of communication during stepping.