Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] set/show code-cache NEWS and doc
Date: Wed, 23 Oct 2013 15:25:00 -0000	[thread overview]
Message-ID: <83sivshuux.fsf@gnu.org> (raw)
In-Reply-To: <1382516855-32218-6-git-send-email-yao@codesourcery.com>

> From: Yao Qi <yao@codesourcery.com>
> Date: Wed, 23 Oct 2013 16:27:35 +0800
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -98,6 +98,12 @@ set range-stepping
>  show range-stepping
>    Control whether target-assisted range stepping is enabled.
>  
> +set code-cache
> +show code-cache
> +  Use more aggressive caching for accesses to the code.  This improves
> +  performance of remote debugging (particularly disassemble) without
> +  affecting correctness.

Thanks.  However, this (and even more importantly, the manual) should
explain what is "code" in this context.  "Code" is too general a word
to hope that the reader will immediately understand what you mean.

Also, the last sentence above should be in the manual; it's not good
that the manual has less details than NEWS.


  reply	other threads:[~2013-10-23 15:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23  8:29 [PATCH 0/5] Cache code access for disassemble Yao Qi
2013-10-23  8:29 ` [PATCH 3/5] set/show code-cache Yao Qi
2013-10-25  7:47   ` Doug Evans
2013-10-25 14:35     ` Yao Qi
2013-10-25 15:57       ` Doug Evans
2013-10-26 13:24         ` Yao Qi
2013-10-28 18:33           ` Doug Evans
2013-10-23  8:29 ` [PATCH 4/5] Use target_read_code in disassemble Yao Qi
2013-10-23  8:29 ` [PATCH 5/5] set/show code-cache NEWS and doc Yao Qi
2013-10-23 15:25   ` Eli Zaretskii [this message]
2013-10-24  8:26     ` Yao Qi
2013-10-24 15:21       ` Eli Zaretskii
     [not found]         ` <526A3B07.1020607@codesourcery.com>
2013-10-25 10:01           ` Eli Zaretskii
2013-11-02  0:25             ` Yao Qi
2013-11-02  7:06               ` Eli Zaretskii
2013-10-23  8:29 ` [PATCH 1/5] Add REGISTRY for struct address_space Yao Qi
2013-10-28 20:46   ` Tom Tromey
2013-10-23  8:29 ` [PATCH 2/5] Associate target_dcache to address_space Yao Qi
2013-10-23 16:37   ` Tom Tromey
2013-10-24  8:33     ` Yao Qi
2013-10-28 20:49       ` Tom Tromey
2013-10-28 21:51   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sivshuux.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox