From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107148-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24286 invoked by alias); 12 Nov 2013 16:39:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24276 invoked by uid 89); 12 Nov 2013 16:39:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from Unknown (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2013 16:38:49 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MW500J00SRR7700@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 12 Nov 2013 18:38:40 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW500IB9SWFTWA0@a-mtaout22.012.net.il>; Tue, 12 Nov 2013 18:38:40 +0200 (IST)
Date: Tue, 12 Nov 2013 17:04:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] New GDB/MI command "-info-gdb-mi-command"
In-reply-to: <1384255504-28444-1-git-send-email-brobecker@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83siv11soi.fsf@gnu.org>
References: <8761rzknb4.fsf@fleche.redhat.com> <1384255504-28444-1-git-send-email-brobecker@adacore.com>
X-IsSubscribed: yes
X-SW-Source: 2013-11/txt/msg00315.txt.bz2

> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 12 Nov 2013 15:25:04 +0400
> 
> This patch adds a new GDB/MI command meant for graphical frontends
> trying to determine whether a given GDB/MI command exists or not.
> 
> Examples:
> 
>     -info-gdb-mi-command unsupported-command
>     ^done,command={exists="false"}
>     (gdb)
>     -info-gdb-mi-command symbol-list-lines
>     ^done,command={exists="true"}
>     (gdb)

Sounds good to me.

> +@subheading The @code{-info-gdb-mi-command} Command
> +@findex -info-gdb-mi-command

This should be prominently indexed with @cindex entries, as this
command is very important, and should be easily found.

> +@subsubheading Synopsis
> +
> +@smallexample
> + -info-gdb-mi-command CMD_NAME
> +@end smallexample
> +
> +Query support for the @sc{gdb/mi} command named @var{CMD_NAME}

Ts-ts-ts... ASCII art habits die hard.  Use @var in the example, and
don't upcase CMD_NAME (it is upcased in Info anyway, and will look
better in print in lower case).

> +(the leading dash (@code{-}) in the command name should be omitted).

Is this wise?  How about if we support both with and without the dash?

> +There is no corresponding @value{GDBN} command.

Having a way of querying that in CLI would facilitate better .gdbinit
files, I think.

> +@smallexample
> +-info-gdb-mi-command symbol-list-lines
> +^done,command=@{exists="true"@}
> +@end smallexample

Btw, why "command="?  Perhaps "result="?

Other than that, the documentation is fine with me.

Thanks.