From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114232-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21236 invoked by alias); 14 Jul 2014 14:55:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21096 invoked by uid 89); 14 Jul 2014 14:55:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout25.012.net.il
Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Jul 2014 14:55:19 +0000
Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N8P00I00IJ67D00@mtaout25.012.net.il> for gdb-patches@sourceware.org; Mon, 14 Jul 2014 17:50:57 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8P00DA2IKX6E50@mtaout25.012.net.il>; Mon, 14 Jul 2014 17:50:57 +0300 (IDT)
Date: Mon, 14 Jul 2014 15:06:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 04/12] record btrace: add configuration struct
In-reply-to: <1405346196-1804-5-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83sim47zxa.fsf@gnu.org>
References: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com> <1405346196-1804-5-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg00337.txt.bz2

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 14 Jul 2014 15:56:28 +0200
> 
> Add a struct to describe the branch trace configuration and use it for
> enabling branch tracing.
> 
> The user will be able to set configuration fields for each tracing format
> to be used for new threads.

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index d9a19ae..f32d1ef 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,17 @@
>  
>  *** Changes since GDB 7.8
>  
> +* New commands (for set/show, see "New options" below)
> +
> +record btrace bts
> +record bts
> +  Start branch trace recording using Intel(R) Branch Trace Store format.
> +
> +* New remote packets
> +
> +qXfer:btrace-conf:read
> +  Return the branch trace configuration for the current thread.
> +
>  *** Changes in GDB 7.8

This part is OK.

> +@table @code
> +@item bts
> +Use Intel's Branch Trace Store (BTS) recording format.  In this format,

Suggest to put "Branch Trace Store" in @dfn and "BTS" in @acronym,
this will look better in print.

Also, there should be @cindex entries for these 2 terms.

The documentation parts are OK with those changes.