From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154565-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 45092 invoked by alias); 12 Mar 2019 17:53:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 44967 invoked by uid 89); 12 Mar 2019 17:53:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-16.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 17:53:38 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59841)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1h3laq-0008K6-GL; Tue, 12 Mar 2019 13:53:36 -0400
Received: from [176.228.60.248] (port=4414 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1h3laq-0004hj-1F; Tue, 12 Mar 2019 13:53:36 -0400
Date: Tue, 12 Mar 2019 17:53:00 -0000
Message-Id: <83sgvs2d46.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
CC: gdb-patches@sourceware.org, palves@redhat.com
In-reply-to: <b6a64fb1265eed6e35e4b8fa1096e7c6@polymtl.ca> (message from Simon	Marchi on Tue, 12 Mar 2019 12:29:48 -0400)
Subject: Re: MinGW build failure for GDB 8.2.90 with source-highlight
References: <83r2bibvlv.fsf@gnu.org> <83ef7d5wak.fsf@gnu.org> <ed82342fcc7e52f9ef3d3031aa69e793@polymtl.ca> <83ef7c3xft.fsf@gnu.org> <b6a64fb1265eed6e35e4b8fa1096e7c6@polymtl.ca>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00253.txt.bz2

> Date: Tue, 12 Mar 2019 12:29:48 -0400
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: gdb-patches@sourceware.org, palves@redhat.com
> 
> > diff --git a/gdb/source-cache.c b/gdb/source-cache.c
> > index 097c8a3..b98272c 100644
> > --- a/gdb/source-cache.c
> > +++ b/gdb/source-cache.c
> > @@ -23,6 +23,8 @@
> >  #include "cli/cli-style.h"
> > 
> >  #ifdef HAVE_SOURCE_HIGHLIGHT
> > +#undef open
> > +#undef close
> >  #include <fstream>
> >  #include <sstream>
> >  #include <srchilite/sourcehighlight.h>
> 
> Thanks, this is fine with me, maybe with a comment explaining why it's 
> needed.  I also think you could push it to the master branch, so that it 
> builds for mingw users.

Done, on both counts.

Thanks for the review.