From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154659-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 50970 invoked by alias); 17 Mar 2019 16:06:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 50956 invoked by uid 89); 17 Mar 2019 16:06:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 16:06:09 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47420)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1h5YIa-0001SN-DO; Sun, 17 Mar 2019 12:06:08 -0400
Received: from [176.228.60.248] (port=3456 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1h5YIZ-0007ry-Go; Sun, 17 Mar 2019 12:06:08 -0400
Date: Sun, 17 Mar 2019 16:06:00 -0000
Message-Id: <83sgvlwknv.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
CC: ssbssa@yahoo.de, tom@tromey.com, gdb-patches@sourceware.org
In-reply-to: <5bb1d8b6-1ee9-3c2b-7a03-224657e2287f@redhat.com> (message from	Pedro Alves on Thu, 14 Mar 2019 20:58:36 +0000)
Subject: Re: [PATCH] Fix scrolling right in the TUI (Re: [RFC 8.3 0/3] Some style fixes)
References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> <87o96g3upj.fsf@tromey.com> <375483967.6114402.1552410513314@mail.yahoo.com> <83lg1i3hkj.fsf@gnu.org> <5bb1d8b6-1ee9-3c2b-7a03-224657e2287f@redhat.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00347.txt.bz2

> Cc: gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 14 Mar 2019 20:58:36 +0000
> 
> On 03/12/2019 05:08 PM, Hannes Domani via gdb-patches wrote:
> > +      if (column <= first_col || column > first_col + line_width)
> > +	{
> > +	  if (c == '\t')
> > +	    {
> > +	      int j, max_tab_len = tui_tab_width;
> > +
> > +	      --column;
> > +	      for (j = column % max_tab_len;
> > +		   j < max_tab_len && column < first_col + line_width;
> > +		   column++, j++)
> > +		if (column >= first_col)
> > +		  result.push_back (' ');
> > +	    }
> > +	  continue;
> > +	}
> 
> instead of duplicating that code, I'd put it in a lambda
> and use it in both places.
> 
> Tromey, WDYT?  Would you prefer the version without the lambda?

Works for me, with the initialization fixed to be 'false'.

Thanks.