From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id L1+9EA8UkmKr3ggAWB0awg (envelope-from ) for ; Sat, 28 May 2022 08:22:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 3A3FF1E221; Sat, 28 May 2022 08:22:39 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=VJac5FWP; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C63F71E143 for ; Sat, 28 May 2022 08:22:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FFB23841895 for ; Sat, 28 May 2022 12:22:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FFB23841895 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653740558; bh=f2IbcpHM7hwvebpbSgmnlIvlH1rp7NS5vjy3TcWu+DA=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VJac5FWPdyKWuFkwOx8PG4NODj1vZc/RgEhe+n68h9bFnOBiebimBvEaidge+GK/V XSEpb8b3/V0L9qnleGU97v0zqaDUD9Vmo1BfNdkf5l3Rg8d/1qR8SLP71YLYFNpTmv 1gqa0rnH/qY2HMUn6zPxpFAETFZkEFouEmCMMXd4= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 962DB3851C21 for ; Sat, 28 May 2022 12:22:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 962DB3851C21 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuvSV-0008Po-7j; Sat, 28 May 2022 08:22:19 -0400 Received: from [87.69.77.57] (port=1306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuvST-0004C1-K9; Sat, 28 May 2022 08:22:19 -0400 Date: Sat, 28 May 2022 15:22:16 +0300 Message-Id: <83sfotludj.fsf@gnu.org> To: ptsneves@gmail.com In-Reply-To: <20220528115509.3865342-3-ptsneves@gmail.com> (message from Paulo Neves via Gdb-patches on Sat, 28 May 2022 13:55:09 +0200) Subject: Re: [PATCH 2/2] gdb/python doc: Add enable property to the unwinder example References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220528115509.3865342-3-ptsneves@gmail.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Sat, 28 May 2022 13:55:09 +0200 > From: Paulo Neves via Gdb-patches > Cc: Paulo Neves > > The enable property is now also in the example code making it clear how > it is used and how it influences the operation of an unwinder. > --- > gdb/doc/python.texi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > index 5b7fba798a9..cb148d9b0ea 100644 > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -2796,6 +2796,10 @@ class FrameId(object): > class MyUnwinder(Unwinder): > def __init__(....): > super(MyUnwinder, self).__init___() > + # If set to True the unwinder will be enabled. > + # If upon registration the enable property is True, the unwinder will be usable immediately. This last line is too long for an @example, please break it into two. > + # gdb or code may change value. > + self.enabled = > > def __call__(pending_frame): > if not : Other than that, this needs to be reviewed by someone who knows about programming unwinders in Python. Thanks.