From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21316 invoked by alias); 14 Apr 2009 14:42:28 -0000 Received: (qmail 21296 invoked by uid 22791); 14 Apr 2009 14:42:26 -0000 X-SWARE-Spam-Status: No, hits=4.2 required=5.0 tests=AWL,BAYES_50,BOTNET,J_CHICKENPOX_13,J_CHICKENPOX_23,J_CHICKENPOX_27,J_CHICKENPOX_63,J_CHICKENPOX_92,J_CHICKENPOX_93,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Apr 2009 14:42:20 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KI300800HXPF300@i-mtaout1.012.net.il> for gdb-patches@sources.redhat.com; Tue, 14 Apr 2009 17:41:35 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.34.97]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KI300JU4I51ZA70@i-mtaout1.012.net.il>; Tue, 14 Apr 2009 17:41:35 +0300 (IDT) Date: Tue, 14 Apr 2009 14:42:00 -0000 From: Eli Zaretskii Subject: Re: needed-list fails in libiberty In-reply-to: To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: <83r5zvmh5v.fsf@gnu.org> References: <83vdp7mile.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00255.txt.bz2 > Date: Tue, 14 Apr 2009 14:19:39 +0000 (UTC) > From: "Joseph S. Myers" > cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com > > On Tue, 14 Apr 2009, Eli Zaretskii wrote: > > > The following snippet from libiberty/Makefile.in: > > > > # needed-list is used by libstdc++. NEEDED is the list of functions > > # to include there. Do not add anything LGPL to this list; libstdc++ > > # can't use anything encumbering. > > Since this comment relates to libstdc++ v2 and GCC 3.0 and later do not > use this, removing all the obsolete code (and maybe everything relating to > building a target libiberty) would be the obvious fix for any problems > with it. Something like this? Btw, what are needed.awk and needed2.awk? should they be deleted as well? 2009-04-14 Eli Zaretskii * Makefile.in (needed-list): Target removed (not used in GCC 3.0 and later). All references deleted. --- libiberty/Makefile.in~ 2009-04-08 18:09:34.906250000 +0300 +++ libiberty/Makefile.in 2009-04-14 17:37:56.796875000 +0300 @@ -100,7 +100,7 @@ SUBDIRS = testsuite # FIXME: add @BUILD_INFO@ once we're sure it works for everyone. -all: stamp-picdir $(TARGETLIB) needed-list required-list all-subdir +all: stamp-picdir $(TARGETLIB) required-list all-subdir @: $(MAKE) ; exec $(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=all .PHONY: check installcheck @@ -377,22 +377,6 @@ mv -f $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB)n $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB) @$(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=install -# needed-list is used by libstdc++. NEEDED is the list of functions -# to include there. Do not add anything LGPL to this list; libstdc++ -# can't use anything encumbering. -NEEDED = atexit calloc memchr memcmp memcpy memmove memset rename strchr \ - strerror strncmp strrchr strstr strtol strtoul tmpnam vfprintf vprintf \ - vfork waitpid bcmp bcopy bzero -needed-list: Makefile - rm -f needed-list; touch needed-list; \ - for f in $(NEEDED); do \ - for g in $(LIBOBJS) $(EXTRA_OFILES); do \ - case "$$g" in \ - *$$f*) echo $$g >> needed-list ;; \ - esac; \ - done; \ - done - # required-list was used when building a shared bfd/opcodes/libiberty # library. I don't know if it used by anything currently. required-list: Makefile @@ -440,8 +424,8 @@ # multiple times, hence our explicit recursion with an empty SUBDIRS. mostlyclean: mostlyclean-subdir -rm -rf *.o pic core errs \#* *.E a.out - -rm -f needed.awk needed2.awk errors dummy needed-list config.h stamp-* - -rm -f $(CONFIG_H) $(NEEDED_LIST) stamp-picdir + -rm -f needed.awk needed2.awk errors dummy config.h stamp-* + -rm -f $(CONFIG_H) stamp-picdir -rm -f libiberty.aux libiberty.cp libiberty.cps libiberty.fn libiberty.ky -rm -f libiberty.log libiberty.tmp libiberty.tps libiberty.pg -rm -f libiberty.pgs libiberty.toc libiberty.tp libiberty.tpl libiberty.vr