From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70571-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10019 invoked by alias); 1 Mar 2010 17:11:42 -0000
Received: (qmail 10006 invoked by uid 22791); 1 Mar 2010 17:11:41 -0000
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Mar 2010 17:11:35 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KYM00F004C6IZ00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 01 Mar 2010 19:11:05 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.54.31]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYM00F6Z52GVV10@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 01 Mar 2010 19:11:05 +0200 (IST)
Date: Mon, 01 Mar 2010 17:11:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin  and MingW builds
In-reply-to: <20100301103125.GB9730@calimero.vinschen.de>
To: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r5o43r2k.fsf@gnu.org>
References: <20100228130500.GG5683@calimero.vinschen.de> <20100228142905.GB1556@caradoc.them.org> <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> <20100228192159.GP5683@calimero.vinschen.de> <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00016.txt.bz2

> Date: Mon, 1 Mar 2010 11:31:25 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> @@ -2296,12 +2297,20 @@ void
>  _initialize_windows_nat (void)
>  {
>    struct cmd_list_element *c;
> +#ifndef __CYGWIN__
> +  static char codepage[32];
> +#endif
>  
>    init_windows_ops ();
>  
>  #ifdef __CYGWIN__
>    cygwin_internal (CW_SET_DOS_FILE_WARNING, 0);
> +  set_auto_target_charset ("UTF-8");
> +#else
> +  snprintf (codepage, 32, "CP%u", GetACP ());
                         ^^
Could this be `sizeof(codepage)' instead, please?

Thanks.