From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4454 invoked by alias); 7 Apr 2010 17:52:20 -0000 Received: (qmail 4438 invoked by uid 22791); 7 Apr 2010 17:52:16 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 17:52:12 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L0I00D00PL9Y300@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 07 Apr 2010 20:52:06 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0I00DGRPMQL310@a-mtaout22.012.net.il>; Wed, 07 Apr 2010 20:52:03 +0300 (IDT) Date: Wed, 07 Apr 2010 17:52:00 -0000 From: Eli Zaretskii Subject: Re: [RFA][python] Add program space support In-reply-to: <20100407173222.A21C584397@ruffy.mtv.corp.google.com> To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83r5mrw3oz.fsf@gnu.org> References: <20100407173222.A21C584397@ruffy.mtv.corp.google.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00145.txt.bz2 > Date: Wed, 7 Apr 2010 10:32:22 -0700 (PDT) > From: dje@google.com (Doug Evans) > > This patch adds basic support for program spaces to python. Thanks. A few comments to the patch for the manual: > doc/ > * gdb.texinfo (Python API): Add progspaces section. > (Selecting Pretty-Printers): Progspace pretty-printers are > searched too. This lacks an entry for the new section you added. > +@node Progspaces In Python > +@subsubsection Progspaces In Python It is okay to use shorthands in node names, but for the section name I'd prefer to use "Program Spaces", the full name. There's no requirement for the two to be identical. > +A program space, or ``progspace'', represents a symbolic view ^^^^^^^^^^^^^ Please use @dfn{progspace} here, it is specifically designed for introducing new terminology. It produces the same quoted string in Info as ``..'', but looks prettier in the printed version. > +A program space, or ``progspace'', represents a symbolic view > +of an address space. An @xref here to where program spaces are described would be useful. > +@findex gdb.current_progspace > +@defun current_progspace > +This function returns the program space of the currently selected inferior. Is this a function or a method? If the latter, we have @defmethod to DTRT. Okay with those changes. Thanks.