From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86289-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27546 invoked by alias); 18 Dec 2011 18:02:57 -0000
Received: (qmail 27535 invoked by uid 22791); 18 Dec 2011 18:02:56 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 18 Dec 2011 18:02:42 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LWE00800VBCYH00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sun, 18 Dec 2011 20:02:39 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.39.203]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LWE00LC5VGD3FA2@a-mtaout22.012.net.il>; Sun, 18 Dec 2011 20:02:39 +0200 (IST)
Date: Sun, 18 Dec 2011 18:45:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Code formatting  [Re: [patch] s390*: watchpoints regression [repost]]
In-reply-to: <20111218172418.GA30764@host2.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: mark.kettenis@xs4all.nl, brobecker@adacore.com, gdb-patches@sourceware.org, pedro@codesourcery.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r501zrjw.fsf@gnu.org>
References: <20111218115931.GA22952@host2.jankratochvil.net> <201112181352.pBIDq9D0023292@glazunov.sibelius.xs4all.nl> <83ty4xzusx.fsf@gnu.org> <20111218172418.GA30764@host2.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00608.txt.bz2

> Date: Sun, 18 Dec 2011 18:24:18 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, brobecker@adacore.com,
>         gdb-patches@sourceware.org, pedro@codesourcery.com
> 
> You dropped the important part about "still going through the shell", that was
> the surprising fact to note there.
> 
> If you do not drop that shell part of the text the Pedro's text becomes
> shorter, therefore more clear.

Then don't drop it.  I think I dropped it by mistake.  Anyway, it was
just an example of how to reword a comment to avoid the problem that
started this thread.

> Also you just describe 
> 
>   /* This is the main thread still going through the shell, or, no
>      watchpoint has been set yet.  */
> ->
>   /* Nothing else to do if this is the main thread, or if no
>      watchpoints have been set yet.  */
> 
> additionally the "return" clause there.  "return" does not need any comment.

"Nothing else to do" explains _why_ we return, which is the point of
the comment, isn't it?