Re: RTTI type improvement for

Tom Tromey
2012-02-06T21:45:26Z

>>>>> "Anton" == xgsa <xgsa@yandex.ru> writes:

Anton> The second part requires this one to be applied, so I'll provide
Anton> it after commit.

It is fine to pipeline patches.
Often it is even preferable to do this, but it depends on how
independent the individual patches actually are.

Anton> +struct value *
Anton> +readjust_indirect_value_type (struct value *value, struct type *enc_type,
Anton> + struct type *original_type,
Anton> + struct value *original_value)

I wonder if there is a cleaner way to do this same thing.
Say, a kind of value constructor as opposed to something that rewrites
an existing value?

If not, that is fine.

Anton> +extern struct value *
Anton> +readjust_indirect_value_type (struct value *value, struct type *enc_type,
Anton> + struct type *original_type,
Anton> + struct value *original_value);

If you're going to split the first line that way, I think you should
indent the subsequent lines by 4 or 5 spaces (not sure what the standard
is, if there is one).

Probably better to split before the open paren though (and still indent;
there are examples of this elsewhere).

Tom