Re: set print object on should affect MI varobjs (PR mi/13393)

Tom Tromey
2012-03-30T17:51:08Z

>>>>> "Anton" == xgsa <xgsa@yandex.ru> writes:

Anton> Waiting for your comments!

Thanks for sending this.
I'm sorry about the delay, I have been quite behind on patch review :(

You didn't say whether you regression-tested this.

I have a few nits, but nothing serious.

AFAIK it still needs a doc review.

Anton> + if (real_type_found)
Anton> + *real_type_found = 0;

Too much indentation on the second line here.

Anton> + if (real_type_found)
Anton> + *real_type_found = 1;

Here too.

Anton> + if (real_type_found)
Anton> + *real_type_found = 1;

Here too.

Anton> + REAL_TYPE_FOUND is used to inform whether the real type was found
Anton> + (or just static type was used). The NULL may be passed if it is not
Anton> + necessary. */

Two spaces after periods.
Just write "NULL", not "The NULL".

Anton> + if (real_type_found)
Anton> + value = value_cast (var->type, value);

Too much indentation.

Anton> + int type_updated = update_type_if_necessary(existing, value);

Space before open paren.

Anton> + curr_type_str = varobj_get_type(var);

Space before open paren.

Anton> + if (update_type_if_necessary(v, new))
Anton> + r.type_changed = 1;

Too much indentation.

Tom