Re: set print object on should affect MI varobjs (PR mi/13393)

xgsa
2012-03-30T20:11:14Z

> You didn't say whether you regression-tested this.
Yes, I didn't say it because I was not sure I have done it properly. I
have run the gdb.mi tests but there were a few unexpected failures.
However these failures are reproducible on gdb master branch without my
changes, so it should be a problem with my environment setup.
Unfortunately, I cannot figure out how to fix it. Moreover probably I
should run all the tests (not only gdb.mi) with "make check" but I
cannot found the overall statistics (only by every module), so it is
quite hard to compare the results. I have read the Testsuite chapter[1]
in gdb internals manual however that didn't help. Can you clarify me how
the regression testing should be done or point me where to read about it?

[1]
http://sourceware.org/gdb/current/onlinedocs/gdbint/Testsuite.html#Testsuite

> Anton> + if (real_type_found)
> Anton> + *real_type_found = 0;
Fixed
> Too much indentation on the second line here.
>
> Anton> + if (real_type_found)
> Anton> + *real_type_found = 1;
>
> Here too.
Fixed
> Anton> + if (real_type_found)
> Anton> + *real_type_found = 1;
>
> Here too.
Fixed
> Anton> + REAL_TYPE_FOUND is used to inform whether the real type was found
> Anton> + (or just static type was used). The NULL may be passed if it is not
> Anton> + necessary. */
>
> Two spaces after periods.
> Just write "NULL", not "The NULL".
Fixed.
> Anton> + if (real_type_found)
> Anton> + value = value_cast (var->type, value);
>
> Too much indentation.
Fixed.
> Anton> + int type_updated = update_type_if_necessary(existing, value);
>
> Space before open paren.
Fixed.
> Anton> + curr_type_str = varobj_get_type(var);
>
> Space before open paren.
Fixed.
> Anton> + if (update_type_if_necessary(v, new))
> Anton> + r.type_changed = 1;
>
> Too much indentation.
Fixed.

Anton.