From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94342-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13606 invoked by alias); 7 Sep 2012 11:27:58 -0000
Received: (qmail 13592 invoked by uid 22791); 7 Sep 2012 11:27:57 -0000
X-SWARE-Spam-Status: No, hits=-4.3 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Sep 2012 11:27:43 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M9Z00M009591500@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Sep 2012 14:27:41 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9Z00LRB965WZ20@a-mtaout22.012.net.il>; Fri, 07 Sep 2012 14:27:41 +0300 (IDT)
Date: Fri, 07 Sep 2012 11:27:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Don't allow setting register in non-innermost frame
In-reply-to: <5049CA30.1040802@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: dje@google.com, tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r4qeax91.fsf@gnu.org>
References: <1345170040-25959-1-git-send-email-yao@codesourcery.com> <CADPb22SGp-9TaoA3rNi_PJordCuv_bjwFQZiHvfjktHx3Y_krA@mail.gmail.com> <87hartpodt.fsf@fleche.redhat.com> <503DE604.5070904@codesourcery.com> <20550.33413.240311.774616@ruffy2.mtv.corp.google.com> <5049C5C5.6000004@codesourcery.com> <83vcfqb0st.fsf@gnu.org> <5049CA30.1040802@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00065.txt.bz2

> Date: Fri, 7 Sep 2012 18:19:28 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <dje@google.com>, <tromey@redhat.com>, <gdb-patches@sourceware.org>
> 
> On 09/07/2012 06:10 PM, Eli Zaretskii wrote:
> >> Date: Fri, 7 Sep 2012 18:00:37 +0800
> >> From: Yao Qi <yao@codesourcery.com>
> >> CC: Tom Tromey <tromey@redhat.com>, <gdb-patches@sourceware.org>
> >>
> >>> I think this is NEWS-worthy.
> >>>
> >>
> >> I add a NEWS entry.
> >
> > Thanks.  But its text says "when assigning" without explaining enough
> > for the reader to understand what "assigning" are we talking about.
> > So I suggest to mention the commands that are affected ('set', IIUC),
> > and perhaps give an example.
> >
> 
> How about them below?
> 
> * GDB will display a warning when assigning to registers, for example
>    "set $eax=0x1", in non-innermost frames.
> 
> or
> 
> * GDB will display a warning when assigning to registers by command
>    "set" in non-innermost frames.

If "set" is the only command, then the second variant is better.  But
isn't the same true of the MI equivalent?