From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98530-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11135 invoked by alias); 14 Feb 2013 22:02:28 -0000
Received: (qmail 11126 invoked by uid 22791); 14 Feb 2013 22:02:27 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 22:02:18 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MI800300D256500@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 15 Feb 2013 00:01:57 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MI8002X8D78YR50@a-mtaout20.012.net.il>; Fri, 15 Feb 2013 00:01:57 +0200 (IST)
Date: Thu, 14 Feb 2013 22:02:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Patch] Get trace file name when using 'target tfile'
In-reply-to: <1360856970.2842.4@abidh-ubunto1104>
To: "Abid, Hafiz" <hafiz_abid@mentor.com>
Cc: palves@redhat.com, yao@codesourcery.com, gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r4kituze.fsf@gnu.org>
References: <1360856970.2842.4@abidh-ubunto1104>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00380.txt.bz2

> Date: Thu, 14 Feb 2013 15:49:30 +0000
> From: "Abid, Hafiz" <hafiz_abid@mentor.com>
> CC: Yao Qi <yao@codesourcery.com>, <gdb-patches@sourceware.org>,
> 	<marc.khouzam@ericsson.com>
> 
> 1. Renamed "from_file" field to "filename". Use explicit NULL(or  
> non-NULL) check against it.
> 2. Added a test case for -trace-struct command.
> 3. Added NEWS entry.
> 
> How does it look?

OK, but:

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -150,6 +150,9 @@ show filename-display
>    ** The response to breakpoint commands and breakpoint async records
>       includes an "installed" field containing a boolean state about each
>       non-pending tracepoint location is whether installed on target or not.
> +  ** Output of the "-trace-status" command includes a "trace-file" field 
> +     containing the name of the trace file being examined. This field is
                                                            ^^
Two spaces between sentences, please.

The documentation parts are OK with that change.  Thanks.