From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17311 invoked by alias); 1 Aug 2013 16:33:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17301 invoked by uid 89); 1 Aug 2013 16:33:52 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from Unknown (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 16:33:51 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MQV003001X1T500@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 01 Aug 2013 19:33:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQV003TG1ZHIL70@a-mtaout20.012.net.il>; Thu, 01 Aug 2013 19:33:17 +0300 (IDT) Date: Thu, 01 Aug 2013 16:33:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 1/3] Detect GDB is in cygwin In-reply-to: <51FA137B.6070207@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83r4edz7z7.fsf@gnu.org> References: <1375087546-22591-1-git-send-email-yao@codesourcery.com> <1375087546-22591-2-git-send-email-yao@codesourcery.com> <83txjdxtpd.fsf@gnu.org> <51F786CB.3020700@codesourcery.com> <83a9l4xdst.fsf@gnu.org> <51FA137B.6070207@codesourcery.com> X-SW-Source: 2013-08/txt/msg00034.txt.bz2 > Date: Thu, 1 Aug 2013 15:51:23 +0800 > From: Yao Qi > CC: > > On 07/30/2013 11:33 PM, Eli Zaretskii wrote: > > There's no need to probe that at configure time: this code can always > > be compiled on any MS-Windows system. The compiler doesn't care and > > doesn't check at compile time whether there is in fact > > NtQueryInformationFile function inside the DLL. > > OK. If so, in configure.ac, we only need to check headers, and don't need > AC_TRY_COMPILE at all. Here is the updated one, with several changes, > > - Remove AC_TRY_COMPILE, > - Include fewer headers in mingw-htep.c, and don't have to check them > in configure.ac. > - Rename is_in_cygwin to using_cygwin_pty, Thanks. I have just one more request: can you verify that GDB will not think it runs in a Cygwin pty when it is run from an MSYS Bash window? (Since MSYS is a fork of an old version of Cygwin, it's possible that it uses the same template for however it sets up the shell window.)