From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105214-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23541 invoked by alias); 11 Sep 2013 16:59:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23529 invoked by uid 89); 11 Sep 2013 16:59:47 -0000
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2013 16:59:47 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MSZ00L000DYAN00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 11 Sep 2013 19:59:34 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MSZ00LY60JA9H20@a-mtaout20.012.net.il>; Wed, 11 Sep 2013 19:59:34 +0300 (IDT)
Date: Wed, 11 Sep 2013 16:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset
In-reply-to: <87ob7zfgc7.fsf@br87z6lw.de.ibm.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r4cvi9ai.fsf@gnu.org>
References: <877genmltz.fsf@br87z6lw.de.ibm.com> <87sixbfkb6.fsf@br87z6lw.de.ibm.com> <83sixbiaqe.fsf@gnu.org> <87ob7zfgc7.fsf@br87z6lw.de.ibm.com>
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00359.txt.bz2

> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Wed, 11 Sep 2013 18:55:36 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> >> Date: Wed, 11 Sep 2013 17:29:49 +0200
> >> 
> >> --- gdb.orig/gdb/NEWS
> >> +++ gdb/gdb/NEWS
> >> @@ -111,6 +111,10 @@ show range-stepping
> >>  * GDB now understands the element 'tvar' in the XML traceframe info.
> >>    It has the id of the collected trace state variables.
> >>  
> >> +* On S/390 targets that provide the transactional-execution feature,
> >> +  the program interruption transaction diagnostic block (TDB) is now
> >> +  represented as a number of additional "registers" in GDB.
> >
> > This part is OK, but the manual should cover this in more detail; I
> > see no reference to "TDB" in your patch for the manual.  So the reader
> > of this NEWS entry will be unable to find any details about this new
> > feature.
> >
> >> --- gdb.orig/gdb/doc/gdb.texinfo
> >> +++ gdb/gdb/doc/gdb.texinfo
> >
> > This part is also OK, except for the above comment.
> 
> Good point.  Do you think the following small addition would be
> appropriate and sufficient?
> 
> 
> --- a/gdb/gdb/doc/gdb.texinfo
> +++ b/gdb/gdb/doc/gdb.texinfo
> @@ -42683,7 +42683,9 @@
>  
>  The @samp{org.gnu.gdb.s390.tdb} feature is optional.  It should
>  contain the 64-bit registers @samp{tdb0}, @samp{tac}, @samp{tct},
> -@samp{atia}, and @samp{tr0} through @samp{tr15}.
> +@samp{atia}, and @samp{tr0} through @samp{tr15}.  These ``registers''
> +represent the appropriate fields in the program interruption
> +transaction diagnostic block (TDB).
>  
>  @node TIC6x Features
>  @subsection TMS320C6x Features

This is OK, but please also add index entries for TDB and "transaction
diagnostic block", so that readers could easily find this text.