From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116193-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15169 invoked by alias); 26 Sep 2014 13:11:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15151 invoked by uid 89); 26 Sep 2014 13:11:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Sep 2014 13:11:18 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NCI00600F9RLP00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 26 Sep 2014 16:11:15 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCI006RXFAQAN70@a-mtaout20.012.net.il>; Fri, 26 Sep 2014 16:11:15 +0300 (IDT)
Date: Fri, 26 Sep 2014 13:11:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/9] New commands `enable probe' and `disable probe'.
In-reply-to: <1411724905-31234-4-git-send-email-jose.marchesi@oracle.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r3yyttlf.fsf@gnu.org>
References: <no@[87.69.4.28]> <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <1411724905-31234-4-git-send-email-jose.marchesi@oracle.com>
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00784.txt.bz2

> From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
> Date: Fri, 26 Sep 2014 11:48:19 +0200
> 
> This patch adds the above-mentioned commands to the generic probe abstraction
> implemented in probe.[ch].  The effects associated to enabling or disabling a
> probe depend on the type of probe being handled, and is triggered by invoking
> two back-end hooks in `probe_ops'.

Thanks.

> +@kindex enable probes
> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}

Is it correct that NAME can be given only if PROVIDER is given, and
OBJFILE can be given only if both NAME and PROVIDER were given?
That's what the nesting of [..] suggests.

Otherwise, the part for the manual is OK.

> +  add_cmd ("probes", no_class, enable_probes_command, _("\
> +Enable probes.\n\
> +Usage: enable probes [PROVIDER [NAME [OBJECT]]]\n\

Same comment as for the manual regarding the nesting of [..].

> +Each argument is a regular expression, used to select probes.\n\
> +PROVIDER matches probe provider names.\n\
> +NAME matches the probe names.\n\
> +OBJECT matches the executable or shared library name.\n\
> +If you do not specify any argument then the command will disable\n\
> +all defined probes."),                                   ^^^^^^^^

A copy/paste typo.

Thanks.