From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29819 invoked by alias); 7 Apr 2015 13:36:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29810 invoked by uid 89); 7 Apr 2015 13:36:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Apr 2015 13:36:56 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NMF00J00V4I0R00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 07 Apr 2015 16:36:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NMF00IQ9V5HQO80@a-mtaout21.012.net.il>; Tue, 07 Apr 2015 16:36:54 +0300 (IDT) Date: Tue, 07 Apr 2015 13:36:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2 15/23] Implement all-stop on top of a target running non-stop mode In-reply-to: <1428410990-28560-16-git-send-email-palves@redhat.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83r3rwhxfm.fsf@gnu.org> References: <1428410990-28560-1-git-send-email-palves@redhat.com> <1428410990-28560-16-git-send-email-palves@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00224.txt.bz2 > From: Pedro Alves > Date: Tue, 7 Apr 2015 13:49:42 +0100 > > gdb/ChangeLog: > 2015-04-07 Pedro Alves > > * NEWS: Mention "maint set/show target-non-stop". > * breakpoint.c (update_global_location_list): Check > target_is_non_stop_p instead of non_stop. > * infcmd.c (attach_command_post_wait, attach_command): Likewise. > * infrun.c (show_can_use_displaced_stepping) > (can_use_displaced_stepping_p, start_step_over_inferior): > Likewise. > (resume): Always resume a single thread if the target is in > non-stop mode. > (proceed): Check target_is_non_stop_p instead of non_stop. If in > all-mode but the target is always in non-stop mode, start all the > other threads that are implicitly resumed too. > (for_each_just_stopped_thread, fetch_inferior_event) > (adjust_pc_after_break, stop_all_threads): Check > target_is_non_stop_p instead of non_stop. > (handle_inferior_event): Likewise. Handle detach-fork in all-stop > with the target always in non-stop mode. > (handle_signal_stop) : If we get a signal while > stepping over a breakpoint, and the target is always in non-stop > mode, restart all threads. > (switch_back_to_stepped_thread): Check target_is_non_stop_p > instead of non_stop. > (keep_going_stepped_thread): Always resume a single thread if the > target is in non-stop mode. > (stop_waiting): If in all-stop mode, and the target is in non-stop > mode, stop all threads. > (keep_going_pass): Likewise, when starting a new in-line step-over > sequence. > * linux-nat.c (get_pending_status, select_event_lwp) > (linux_nat_filter_event, linux_nat_wait_1, linux_nat_wait): Check > target_is_non_stop_p instead of non_stop. > (linux_nat_always_non_stop_p): New function. > (linux_nat_stop): Check target_is_non_stop_p instead of non_stop. > (linux_nat_add_target): Install linux_nat_always_non_stop_p. > * target-delegates.c: Regenerate. > * target.c (target_is_non_stop_p): New function. > (target_non_stop_enabled, target_non_stop_enabled_1): New globals. > (maint_set_target_non_stop_command) > (maint_show_target_non_stop_command): New functions. > (_initilize_target): Install "maint set/show target-non-stop" > commands. > * target.h (struct target_ops) : New field. > (target_non_stop_enabled): New declaration. > (target_is_non_stop_p): New declaration. > > gdb/doc/ChangeLog: > 2015-04-07 Pedro Alves > > * gdb.texinfo (Maintenance Commands): Document "maint set/show > target-non-stop". > > v2: > > - Documentation adjusted per Eli's review. NEWS entry added. > - `proceed' change simplified, thanks to fixes in v2 of previous > patches in the series. OK for the documentation parts. Thanks.