From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78371 invoked by alias); 5 Dec 2015 08:02:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78358 invoked by uid 89); 5 Dec 2015 08:02:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_FAIL autolearn=no version=3.3.2 X-HELO: mtaout29.012.net.il Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 05 Dec 2015 08:02:25 +0000 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NYV00900K0DCA00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Sat, 05 Dec 2015 10:00:57 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYV009QZKXLBZ40@mtaout29.012.net.il>; Sat, 05 Dec 2015 10:00:57 +0200 (IST) Date: Sat, 05 Dec 2015 08:02:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v3 2/2] Implement 'catch syscall' for gdbserver In-reply-to: <5662489B.20708@redhat.com> To: Josh Stone Cc: gdb-patches@sourceware.org, philippe.waroquiers@skynet.be, sergiodj@redhat.com, palves@redhat.com, xdje42@gmail.com Reply-to: Eli Zaretskii Message-id: <83r3j1fhoq.fsf@gnu.org> References: <1448506425-24691-1-git-send-email-jistone@redhat.com> <1449196006-13759-1-git-send-email-jistone@redhat.com> <1449196006-13759-2-git-send-email-jistone@redhat.com> <837fkuiovv.fsf@gnu.org> <5662489B.20708@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00100.txt.bz2 > Cc: gdb-patches@sourceware.org, philippe.waroquiers@skynet.be, > sergiodj@redhat.com, palves@redhat.com, xdje42@gmail.com > From: Josh Stone > Date: Fri, 4 Dec 2015 18:14:51 -0800 > > On 12/04/2015 12:44 AM, Eli Zaretskii wrote: > >> From: Josh Stone > >> Cc: philippe.waroquiers@skynet.be, sergiodj@redhat.com, palves@redhat.com, eliz@gnu.org, xdje42@gmail.com, Josh Stone > >> Date: Thu, 3 Dec 2015 18:26:46 -0800 > >> > >> This adds a new QCatchSyscalls packet to enable 'catch syscall', and new > >> stop reasons "syscall_entry" and "syscall_return" for those events. It > >> is currently only supported on Linux x86 and x86_64. > >> > >> gdb/ChangeLog: > >> > >> 2015-12-03 Josh Stone > >> Philippe Waroquiers > >> > >> * NEWS (Changes since GDB 7.10): Mention QCatchSyscalls and new > >> GDBserver support for catch syscall. > >> * remote.c (PACKET_QCatchSyscalls): New enum. > >> (remote_set_syscall_catchpoint): New function. > >> (remote_protocol_features): New element for QCatchSyscalls. > >> (remote_parse_stop_reply): Parse syscall_entry/return stops. > >> (init_remote_ops): Install remote_set_syscall_catchpoint. > >> (_initialize_remote): Config QCatchSyscalls. > >> * linux-nat.h (struct lwp_info) : Comment typo. > >> > >> gdb/doc/ChangeLog: > >> > >> 2015-12-03 Josh Stone > >> Philippe Waroquiers > >> > >> * gdb.texinfo (Remote Configuration): List the QCatchSyscalls packet. > >> (Stop Reply Packets): List the syscall entry and return stop reasons. > >> (General Query Packets): Describe QCatchSyscalls, and add it to the > >> table and detailed list of stub features. > > > > Any changes since v2 in the documentation parts that require a fresh > > review? > > I made the changes you requested in v2 -- v3 just has some > merge-resolution in NEWS. But Pedro has noted some more things to > document for the next round. Then I guess it's better if I review the next round, is that right? Or do you mean this v3 _is_ that next round? Thanks.