From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-139055-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 37049 invoked by alias); 13 May 2017 08:12:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 36951 invoked by uid 89); 13 May 2017 08:12:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:gdb-pat, sk:gdbpat, H*r:134
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 May 2017 08:12:00 +0000
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1d9S9c-0000EU-TH	for gdb-patches@sourceware.org; Sat, 13 May 2017 04:12:01 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44398)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1d9S9c-0000E5-Qa; Sat, 13 May 2017 04:11:56 -0400
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3532 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1d9S9b-0003nz-MU; Sat, 13 May 2017 04:11:56 -0400
Date: Sat, 13 May 2017 08:12:00 -0000
Message-Id: <83r2zt89c8.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <qiyaoltc@gmail.com>
CC: gdb-patches@sourceware.org
In-reply-to:	<CAH=s-PM+ZXw6T9+2feqp0tr479bnwFFDUTgkpoF-5QOk3Qi9pQ@mail.gmail.com>	(message from Yao Qi on Tue, 9 May 2017 11:17:25 +0100)
Subject: Re: GDB 7.99.91 MinGW compilation warning in tui.c
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <20170504194442.63AAF60B72@joel.gnat.com> <83mvancrze.fsf@gnu.org>  <CAH=s-PM+ZXw6T9+2feqp0tr479bnwFFDUTgkpoF-5QOk3Qi9pQ@mail.gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-IsSubscribed: yes
X-SW-Source: 2017-05/txt/msg00315.txt.bz2

> From: Yao Qi <qiyaoltc@gmail.com>
> Date: Tue, 9 May 2017 11:17:25 +0100
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> 
> On Mon, May 8, 2017 at 4:01 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >        tui/tui.c: In function 'void tui_enable()':
> >        tui/tui.c:430:39: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
> >          s = newterm ("unknown", stdout, stdin);
> >                                               ^
> > I fixed this by explicitly casting "unknown" to 'char *' -- is that
> > the right fix?  Is it OK to push that fix?
> >
> 
> Yes, I think so, we've done this before
> https://sourceware.org/ml/gdb-patches/2017-04/msg00032.html

Thanks, pushed.