Re: [RFA v3 07/13] Throw a "quit" on a KeyboardException in py-framefilter.c

Tom Tromey
2018-03-25T16:37:55Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 03/23/2018 08:55 PM, Tom Tromey wrote:
>> +set test "bt 1 with KeyboardInterrupt"
>> +gdb_test_multiple "bt 1" $test {
>> + -re "Quit" {
>> + pass $test
>> + }
>> +}

Pedro> What's the gdb output in gdb.log in this case? Is there a GDB prompt
Pedro> involved?

Here's what gdb.log says:

bt 1
#0 Quit
(gdb) PASS: gdb.python/py-framefilter.exp: bt 1 with KeyboardInterrupt

The test is making a frame filter that throws a KeyboardInterrupt when
called, to simulate the user interrupting the backtrace.

Pedro> I'm wondering whether this is racy as is. Does e.g., the test pass
Pedro> with "make check-read1"?

This works fine.

Pedro> Or, are we leaving a gdb prompt in the expect buffer unprocessed?

I don't think so but I guess I am not really sure.

Tom