From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110156 invoked by alias); 6 Jul 2018 12:37:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109830 invoked by uid 89); 6 Jul 2018 12:37:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Two X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jul 2018 12:37:24 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbPzC-0007S1-0H for gdb-patches@sourceware.org; Fri, 06 Jul 2018 08:37:22 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbPzB-0007Rv-SD; Fri, 06 Jul 2018 08:37:17 -0400 Received: from [176.228.60.248] (port=3928 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbPzB-0002BU-BB; Fri, 06 Jul 2018 08:37:17 -0400 Date: Fri, 06 Jul 2018 12:37:00 -0000 Message-Id: <83r2kglev4.fsf@gnu.org> From: Eli Zaretskii To: Jan Vrany CC: gdb-patches@sourceware.org In-reply-to: <20180706093925.27733-1-jan.vrany@fit.cvut.cz> (message from Jan Vrany on Fri, 6 Jul 2018 10:39:25 +0100) Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command References: <20180706093925.27733-1-jan.vrany@fit.cvut.cz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00145.txt.bz2 > From: Jan Vrany > Cc: Jan Vrany > Date: Fri, 6 Jul 2018 10:39:25 +0100 > > A CLI command "disassemble" allows use to specify a single > address - in that case function surrounding that address is > disassembled. > > This commit adds this feature to MI command "-data-disassemble". Thanks. > @@ -30959,6 +30960,9 @@ Where: > is the beginning address (or @code{$pc}) > @item @var{end-addr} > is the end address > +@item @var{addr} > +is the address anywhere in function code (or function name). If @var{addr} ^^ Two spaces between sentences, please. > +is specified, whole function surrounding that address will be disassembled. ^^^^^^^^^^^^^^ "the whole function" Also, since ADDR could be the name of a function, I'd add here a sentence describing that situation, since there could be no function "surrounding" a function name. What about NEWS? The documentation part is approved when the above nits are fixed.