From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2 4/6] Document changes to info [args|functions|locals|variables]
Date: Sun, 26 Aug 2018 18:19:00 -0000 [thread overview]
Message-ID: <83r2il56uz.fsf@gnu.org> (raw)
In-Reply-To: <20180826165359.1600-5-philippe.waroquiers@skynet.be> (message from Philippe Waroquiers on Sun, 26 Aug 2018 18:53:57 +0200)
> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 26 Aug 2018 18:53:57 +0200
>
> Document changes to info [args|functions|locals|variables]
>
> gdb/doc/ChangeLog
> 2018-08-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * gdb.texinfo (Information About a Frame): Document changes
> to 'info args' and 'info locals'.
> (Examining the Symbol Table): Document changes to 'info functions'
> and 'info variables'.
Thanks. I have one minor comment:
> +If @var{type_regexp} is provided, print only the arguments whose
> +types contain a match for regular expression @var{type_regexp}.
> +The matching is done with the argument type as printed by the
> +@code{whatis} command.
I'd rephrase these two sentences as one, and while at that lose one
instance of passive tense:
If @var{type_regexp} is provided, print only the arguments whose
types, as printed by the @code{whatis} command, contain a match for
regular expression @var{type_regexp}.
> +Initialization types (RAII) such as @code{lock_something_t} : each
^
That blank is redundant.
OK with this fixed.
next prev parent reply other threads:[~2018-08-26 18:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 16:54 [RFAv2 0/6] info [args|functions|locals|variables] [-q] [-t TYPEREGEXP] [NAMEREGEXP] Philippe Waroquiers
2018-08-26 16:54 ` [RFAv2 6/6] Add a test case for info args|functions|locals|variables " Philippe Waroquiers
2018-08-26 16:54 ` [RFAv2 2/6] Make struct type_print_options default_ptype_flags non static Philippe Waroquiers
2018-08-26 16:54 ` [RFAv2 1/6] New cli-utils.h/.c function extract_info_print_args Philippe Waroquiers
2018-09-18 15:31 ` Tom Tromey
2018-09-23 20:16 ` Philippe Waroquiers
2018-09-24 13:07 ` Tom Tromey
2018-09-25 4:37 ` Philippe Waroquiers
2018-08-26 16:54 ` [RFAv2 4/6] Document changes to info [args|functions|locals|variables] Philippe Waroquiers
2018-08-26 18:19 ` Eli Zaretskii [this message]
2018-08-26 16:54 ` [RFAv2 5/6] Announce changes in NEWS " Philippe Waroquiers
2018-08-26 18:21 ` Eli Zaretskii
2018-08-27 4:39 ` Philippe Waroquiers
2018-08-27 14:59 ` Eli Zaretskii
2018-08-26 16:54 ` [RFAv2 3/6] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args " Philippe Waroquiers
2018-09-18 15:52 ` Tom Tromey
2018-09-23 21:34 ` Philippe Waroquiers
2018-09-06 20:16 ` PING Re: [RFAv2 0/6] info [args|functions|locals|variables] [-q] [-t TYPEREGEXP] [NAMEREGEXP] Philippe Waroquiers
2018-09-13 19:27 ` PING^2 " Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r2il56uz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox