From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154514-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 99510 invoked by alias); 9 Mar 2019 06:17:03 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 99499 invoked by uid 89); 9 Mar 2019 06:17:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Mar 2019 06:17:02 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:53686)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1h2VI4-0000be-G4; Sat, 09 Mar 2019 01:17:00 -0500
Received: from [176.228.60.248] (port=3990 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1h2VI3-00032V-SP; Sat, 09 Mar 2019 01:17:00 -0500
Date: Sat, 09 Mar 2019 06:17:00 -0000
Message-Id: <83r2bg8tdd.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
CC: gdb-patches@sourceware.org
In-reply-to: <20190308210433.32683-3-tromey@adacore.com> (message from Tom	Tromey on Fri, 8 Mar 2019 14:04:32 -0700)
Subject: Re: [RFC 8.3 2/3] Add the "set style source" command
References: <20190308210433.32683-1-tromey@adacore.com> <20190308210433.32683-3-tromey@adacore.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00202.txt.bz2

> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>
> Date: Fri,  8 Mar 2019 14:04:32 -0700
> 
> This adds "set style source" (and "show style source") commands.  This
> gives the user control over whether source code is highlighted.

Thanks.

> +set style sources [on|off]
> +show style sources
> +  Enable or disable source code styling.  Source code styling is
> +  enabled by default, but only takes effect if styling in general is
> +  enabled, if if GDB was linked with GNU Source Highlight.
              ^^^^^
A typo (you probably meant "and if").

Otherwise, the documentation parts are OK, thanks.