From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53379 invoked by alias); 17 Mar 2019 16:07:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53371 invoked by uid 89); 17 Mar 2019 16:07:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:6ada07d, HContent-type:charset, HContent-type:text, HContent-type:plain X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 16:07:46 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5YK9-0002MC-3D; Sun, 17 Mar 2019 12:07:45 -0400 Received: from [176.228.60.248] (port=3555 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5YK8-0006yh-EG; Sun, 17 Mar 2019 12:07:44 -0400 Date: Sun, 17 Mar 2019 16:07:00 -0000 Message-Id: <83r2b5wkl5.fsf@gnu.org> From: Eli Zaretskii To: Hannes Domani CC: gdb-patches@sourceware.org In-reply-to: <186859064.9289078.1552667917410@mail.yahoo.com> (gdb-patches@sourceware.org) Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight References: <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com> <186859064.9289078.1552667917410@mail.yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00348.txt.bz2 > Date: Fri, 15 Mar 2019 16:38:37 +0000 (UTC) > From: "Hannes Domani via gdb-patches" > > Also, I had to add the following to make it work on windows > (but beware, I'm using pdcurses, not ncurses, and I don't know if ncurses > for windows needs this as well): Ncurses doesn't need this. > --- a/gdb/tui/tui-io.c > +++ b/gdb/tui/tui-io.c > @@ -369,6 +386,17 @@ apply_ansi_escape (WINDOW *w, const char *buf) > >    if (reverse_mode_p) >      { > +#if defined(__MINGW32__) > +      if (style.get_foreground ().is_basic () > +         && style.get_foreground ().get_value () > +         == (ncurses_norm_attr & 15)) > +       style.set_fg (ui_file_style::NONE); > +      if (style.get_background ().is_basic () > +         && style.get_background ().get_value () > +         == ((ncurses_norm_attr >> 4) & 15)) > +       style.set_bg (ui_file_style::NONE); > +#endif > + Could you describe what happens with pdcurses if you don't make this change? It's strange that pdcurses cannot use explicit color specification if the color is the default one.