From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24272 invoked by alias); 21 Mar 2019 18:38:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24263 invoked by uid 89); 21 Mar 2019 18:38:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1059, HContent-type:charset, HContent-type:text X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 18:38:17 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h72Zz-0002jj-D4; Thu, 21 Mar 2019 14:38:15 -0400 Received: from [176.228.60.248] (port=3441 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h72Zy-0004k6-If; Thu, 21 Mar 2019 14:38:15 -0400 Date: Thu, 21 Mar 2019 18:38:00 -0000 Message-Id: <83r2b0t6ne.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: simark@simark.ca, tom@tromey.com, gdb-patches@sourceware.org In-reply-to: <9683c17d-d05d-3be9-b2cd-1d56356617df@redhat.com> (message from Pedro Alves on Thu, 21 Mar 2019 18:19:04 +0000) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83d0n8eyzw.fsf@gnu.org> <87d0n6adk2.fsf@tromey.com> <83imwyee29.fsf@gnu.org> <87d0n67d29.fsf@tromey.com> <83imwwc7pj.fsf@gnu.org> <57558f60-8254-931f-846b-bdd6b60f5798@simark.ca> <838sx8uwbb.fsf@gnu.org> <834l7wushq.fsf@gnu.org> <0f1760b45f024d45ceece8f0fe5c2686@simark.ca> <83zhpotb38.fsf@gnu.org> <0e500186-b830-75a3-b3f8-9e5688404c5a@simark.ca> <9683c17d-d05d-3be9-b2cd-1d56356617df@redhat.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00470.txt.bz2 > Cc: tom@tromey.com, gdb-patches@sourceware.org > From: Pedro Alves > Date: Thu, 21 Mar 2019 18:19:04 +0000 > > > if $_gdb_version_major >= 9 \ > >    || ($_gdb_version_major >= 8 && $gdb_version_minor >= 5 > > > > If you need to check for a range, it's even more complicated. > > > > But then, if the version is provided as separate components, nothing prevents you to re-encode it however you want after that.  You can do easily enough > > > > set $my_gdb_version = ($_gdb_version_major * 100) + $_gdb_version_minor > > > > if you want, and use the simple comparison.  And everyone is free to choose their own encoding :).  So, to me separate components sounds better. > > Exactly my thoughts. That's what the GCC manual describes, BTW: > > https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html And I've seen my share of erroneous version checks using the GCC macros. But if there's a consensus to go with 2 separate numbers, I'm okay with redoing the patch that way.