From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54066 invoked by alias); 21 Apr 2019 05:19:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54049 invoked by uid 89); 21 Apr 2019 05:19:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 21 Apr 2019 05:19:53 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hI4tL-00073r-EP; Sun, 21 Apr 2019 01:19:51 -0400 Received: from [176.228.60.248] (port=3089 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hI4tK-0005fD-Uo; Sun, 21 Apr 2019 01:19:51 -0400 Date: Sun, 21 Apr 2019 05:19:00 -0000 Message-Id: <83r29w9bpw.fsf@gnu.org> From: Eli Zaretskii To: Philippe Waroquiers CC: gdb-patches@sourceware.org In-reply-to: <20190420212153.30934-3-philippe.waroquiers@skynet.be> (message from Philippe Waroquiers on Sat, 20 Apr 2019 23:21:51 +0200) Subject: Re: [RFA 2/4] Implement | (pipe) command. References: <20190420212153.30934-1-philippe.waroquiers@skynet.be> <20190420212153.30934-3-philippe.waroquiers@skynet.be> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00401.txt.bz2 > From: Philippe Waroquiers > Cc: Philippe Waroquiers > Date: Sat, 20 Apr 2019 23:21:51 +0200 > > + if (shell_command_status > 0) > + { > + if (WIFEXITED (shell_command_status)) > + warning (_("shell command \"%s\" exit status %d"), shell_command, > + WEXITSTATUS (shell_command_status)); > + else if (WIFSIGNALED (shell_command_status)) > + warning (_("shell command \"%s\" exit with signal %d"), shell_command, > + WTERMSIG (shell_command_status)); These macros will need to be ported to MinGW, since the current definitions in gdb_wait.h are for Posix systems (and never used on anything other than that). Gnulib has replacements, but they are less functional on Windows than I'd like them to be, in particular when the shell program exited due to a signal. I can provide better replacements if you want.