From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118965 invoked by alias); 27 Jun 2019 17:35:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118956 invoked by uid 89); 27 Jun 2019 17:35:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jun 2019 17:35:53 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hgYJJ-0006Dx-7l; Thu, 27 Jun 2019 13:35:49 -0400 Received: from [176.228.60.248] (port=3778 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hgYJH-0000K0-C9; Thu, 27 Jun 2019 13:35:48 -0400 Date: Thu, 27 Jun 2019 17:35:00 -0000 Message-Id: <83r27fhqxo.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20190627145235.21222-5-tromey@adacore.com> (message from Tom Tromey on Thu, 27 Jun 2019 08:52:35 -0600) Subject: Re: [PATCH 4/4] Add $_ada_exception convenience variable References: <20190627145235.21222-1-tromey@adacore.com> <20190627145235.21222-5-tromey@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00619.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Thu, 27 Jun 2019 08:52:35 -0600 > > diff --git a/gdb/NEWS b/gdb/NEWS > index 2cc82e86560..7379fd78b41 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -25,6 +25,9 @@ > provide the exitcode or exit status of the shell commands launched by > GDB commands such as "shell", "pipe" and "make". > > +* New convenience variable $_ada_exception holds the address of the > + Ada exception being thrown. This is set by Ada-related catchpoints. > + This part is OK. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 55be2ef6920..1a69c444e37 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -4695,10 +4695,18 @@ called @code{Constraint_Error} is defined in package @code{Pck}, then > the command to use to catch such exceptions is @kbd{catch exception > Pck.Constraint_Error}. > > +The convenience variable @code{$_ada_exception} holds the address of > +the exception being thrown. This can be useful when setting a > +condition for such a catchpoint. > + > @item exception unhandled > @kindex catch exception unhandled > An exception that was raised but is not handled by the program. > > +The convenience variable @code{$_ada_exception} holds the address of > +the exception being thrown. This can be useful when setting a > +condition for such a catchpoint. > + > @item handlers @r{[}@var{name}@r{]} > @kindex catch handlers > @cindex Ada exception handlers catching > @@ -4719,9 +4727,14 @@ user-defined one. For instance, assuming an exception called > command to use to catch such exceptions handling is > @kbd{catch handlers Pck.Constraint_Error}. > > +The convenience variable @code{$_ada_exception} holds the address of > +the exception being thrown. This can be useful when setting a > +condition for such a catchpoint. Here I wonder why we need to have the exact same text 3 times within less than 25 lines. Can't we say this only once? Otherwise the documentation parts are fine, thanks.