From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-163943-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 92739 invoked by alias); 8 Feb 2020 20:13:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 92730 invoked by uid 89); 8 Feb 2020 20:13:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1231
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Feb 2020 20:13:46 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49174)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1j0WU3-00037u-Eo; Sat, 08 Feb 2020 15:13:43 -0500
Received: from [176.228.60.248] (port=2664 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1j0WU2-0003Cc-GY; Sat, 08 Feb 2020 15:13:43 -0500
Date: Sat, 08 Feb 2020 20:13:00 -0000
Message-Id: <83r1z4dehn.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simark@simark.ca>
CC: ssbssa@yahoo.de, gdb-patches@sourceware.org
In-reply-to: <f1db8d62-68d7-b912-89e4-1b83127ebea3@simark.ca> (message from	Simon Marchi on Sat, 8 Feb 2020 15:00:10 -0500)
Subject: Re: [PATCH v2 1/2] Display ExceptionRecord for $_siginfo
References: <20200208162614.4918-1-ssbssa.ref@yahoo.de> <20200208162614.4918-1-ssbssa@yahoo.de> <f1db8d62-68d7-b912-89e4-1b83127ebea3@simark.ca>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2020-02/txt/msg00245.txt.bz2

> From: Simon Marchi <simark@simark.ca>
> Date: Sat, 8 Feb 2020 15:00:10 -0500
> 
> > Program received signal SIGSEGV, Segmentation fault.
> > main () at crasher.c:4
> > 4         *(int*)0x123 = 0;
> > (gdb) p $_siginfo
> > $1 = {
> >   ExceptionCode = 3221225477,
> >   ExceptionFlags = 0,
> >   ExceptionRecord = 0x0,
> >   ExceptionAddress = 0x401632 <main+18>,
> >   NumberParameters = 2,
> >   ExceptionInformation = {1, 291, 0 <repeats 13 times>}
> > }
> > (gdb) p/x $_siginfo.ExceptionCode
> > $2 = 0xc0000005
> > (gdb) p/x $_siginfo.ExceptionInformation[1]
> > $3 = 0x123
> > 
> > And 0xc0000005 is the value of EXCEPTION_ACCESS_VIOLATION.
> > 
> > [1] https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-exception_record
> 
> Eli, could you please comment on this from a Windows user point of view, if this looks
> correct to you?

LGTM, although I'd prefer to have ExceptionCode be printed in hex by
default.  But I guess that could be tricky, and the next patch makes
then print as symbolic names anyway.

> Also, does this need a manual/NEWS update?

I think only NEWS, because the manual already says "on some targets",
and gives an example from GNU/Linux only.

Thanks.