From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z0FcIE4ClmLMdQkAWB0awg (envelope-from ) for ; Tue, 31 May 2022 07:55:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 75CBC1E221; Tue, 31 May 2022 07:55:58 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=QWiLyN6/; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 054611E00D for ; Tue, 31 May 2022 07:55:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 99AD13857BBC for ; Tue, 31 May 2022 11:55:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99AD13857BBC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653998157; bh=G6eHE0C3KFiz35RFwa8NbNoVnP1so/4NzTWuDNRbtl0=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QWiLyN6/ZnW4hXaWjgz2Tfn/aI1tD4oMT/j9HgzR89VRbShlJ6z+Ai/iJ7XMYh1S6 EAh5GzhCg+bnNw37EXyBS6g/Seul0KjzP/WAA7Y9vMiWnELsAlVhY+8VagiU3FJ0YY IpJWv58yK2z3B/QzUZC4QXv+DN/JlPBOCIZh1/3g= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6DBEA3858D33 for ; Tue, 31 May 2022 11:55:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6DBEA3858D33 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw0TI-0000Ag-4c; Tue, 31 May 2022 07:55:36 -0400 Received: from [87.69.77.57] (port=3745 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw0TH-0004sO-KX; Tue, 31 May 2022 07:55:35 -0400 Date: Tue, 31 May 2022 14:55:41 +0300 Message-Id: <83r149j4qq.fsf@gnu.org> To: Pedro Alves In-Reply-To: (message from Pedro Alves on Tue, 31 May 2022 12:31:40 +0100) Subject: Re: [PATCH] Improve break-range's documentation References: <20220526194250.2310460-1-pedro@palves.net> <838rqmm7gb.fsf@gnu.org> <6914f754-4e33-5aa1-4ea6-dca9504e8bfe@palves.net> <837d63j8tx.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Tue, 31 May 2022 12:31:40 +0100 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > > Set a breakpoint for an address range given by @var{start-locspec} and > @var{end-locspec}, which are location specs. @xref{Location > Specifications}, for a list of all the possible forms of location > -specs. If either @var{start-locspec} or @var{end-locspec} resolve to > -multiple addresses in the program, then the command aborts with an > -error without creating a breakpoint. The breakpoint will stop > -execution of the inferior whenever it executes an instruction at any > -address within the specified range, including @var{start-locspec} and > -@var{end-locspec}. > +specs. @value{GDBN} resolves both @var{start-locspec} and > +@var{end-locspec}, and uses the addresses of the resolved code > +locations as start and end addresses of the range to break at. If > +either @var{start-locspec} or @var{end-locspec} resolve to multiple > +code locations in the program, then the command aborts with an error > +without creating a breakpoint. The breakpoint will stop execution of > +the inferior whenever it executes an instruction at any address > +between the start and end addresses, inclusive. This is fine, but please swap the last sentence with the one before it, since, as written, the penultimate sentence breaks the logic of the description of what the command does by describing an exceptional situation too early. Thanks.