RE: Process record and replay checked in to main trunk

Pierre Muller
2009-05-08T12:11:19Z

I tested this both in 32bit and 64bit CORE_ADDR length.

I can confirm that cygwin compilation is fixed in both
cases with that patch and hope it will be approved
rapidly.

Thanks, Hui.

Pierre Muller
Pascal language support maintainer for GDB

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Hui Zhu
> Envoyé : Friday, May 08, 2009 7:12 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; Michael Snyder; Pedro Alves
> Objet : Re: Process record and replay checked in to main trunk
>
> Hi Pierre,
>
> I make a patch to fix this bug, but I don't have cygwin.
>
> Could you please help me test this patch in cygwin?
>
> Thanks,
> Hui
>
> On Fri, May 8, 2009 at 07:06, Pedro Alves <pedro@codesourcery.com>
> wrote:
> > On Thursday 07 May 2009 23:43:13, Michael Snyder wrote:
> >> Guessing it isn't implemented for 64 bit.
> >
> > I don't think that's the problem here.  Cygwin is 32-bit, and has
> > 32-bit ints.
> >
> >> ../../purecvs/gdb/linux-record.c:397: warning: unsigned int format,
> >> uint32_t arg
> >
> >> ../../purecvs/gdb/linux-record.c:629: warning: int format, uint32_t
> >> arg (arg
> >
> > Better use casts, or use plongest/pulongest/hex_string where
> appropriate?
> >
> >> Perhaps we should have a --disable-process-record config option?
> >> If only for a back-up plan?
> >
> > I think that would be more work than fixing this properly.  :-)
> >
> >> ../../purecvs/gdb/linux-record.c:1636: error: `F_GETLK64' undeclared
> >> (first use in this function)
> >
> > There are a bunch of RECORD_* macros defined on top of linux-record.c
> > to replace contants like these.  E.g., RECORD_Q_GETFMT.  Looks like
> > this case was just missed.
> >
> > --
> > Pedro Alves
> >