From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93258-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20831 invoked by alias); 28 Jul 2012 06:53:40 -0000
Received: (qmail 20823 invoked by uid 22791); 28 Jul 2012 06:53:38 -0000
X-SWARE-Spam-Status: No, hits=-4.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL,TW_FD
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Jul 2012 06:53:23 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M7U00M00YWMLT00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 28 Jul 2012 09:53:22 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M7U00M36Z4X3DC0@a-mtaout22.012.net.il>; Sat, 28 Jul 2012 09:53:22 +0300 (IDT)
Date: Sat, 28 Jul 2012 06:53:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/4]: Make "python" start a standard Python prompt
In-reply-to: <17C09F4A-E788-4ABE-926E-7113ACB97651@cs.umd.edu>
To: Khoo Yit Phang <khooyp@cs.umd.edu>
Cc: tromey@redhat.com, pmuldoon@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83pq7gidg5.fsf@gnu.org>
References: <770F6E2B-70F5-4DF9-8E01-BD4F5FDC7AB1@cs.umd.edu> <500F95FB.5060904@redhat.com> <87zk6nizl6.fsf@fleche.redhat.com> <1C2FC4AD-E6FE-4857-9DE5-FDE5BE006E95@cs.umd.edu> <874novivob.fsf@fleche.redhat.com> <9DB9F174-129C-4C4A-9708-53A1D521251A@cs.umd.edu> <87mx2nhgch.fsf@fleche.redhat.com> <61B8FB86-D21F-4BA5-B86D-DF0ECF04C29D@cs.umd.edu> <87vchae842.fsf@fleche.redhat.com> <D67657CC-D09F-4FEA-89BC-F00F6A2973B7@cs.umd.edu> <83mx2mjt2j.fsf@gnu.org> <6943FA37-9279-4213-95A6-7C6546A35BE3@cs.umd.edu> <17C09F4A-E788-4ABE-926E-7113ACB97651@cs.umd.edu>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00714.txt.bz2

> From: Khoo Yit Phang <khooyp@cs.umd.edu>
> Date: Thu, 26 Jul 2012 22:32:15 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>, tromey@redhat.com, pmuldoon@redhat.com, gdb-patches@sourceware.org
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -17,6 +17,14 @@
>  maint info bfds
>    List the BFDs known to GDB.
>  
> +python-interactive [command]
> +pi [command]
> +  Start a Python interactive prompt, or evaluate the optional command
> +  and print the result of expressions.
> +
> +py [command]
> +  "py" is a new alias for "python".
> +
>  *** Changes in GDB 7.5

This part is OK.

> +@item python-interactive @r{[}@var{code}@r{]}
> +@itemx pi @r{[}@var{code}@r{]}

Why "code"?  Elsewhere you used "command", which is better, IMO.

> +The @code{python-interactive} command can be used to start an
> +interactive Python prompt.

"Without an argument, the @code{python-interactive} command can be
used ..."

> +Alternatively, a single-line Python command can be given as an
> +argument, and if the command is an expression, the result will be
> +printed.

And if the command is not an expression, what happens then?

>  @item python @r{[}@var{code}@r{]}
> +@itemx py @r{[}@var{code}@r{]}

Again, I think "code" is not a good term here.