From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17013 invoked by alias); 18 Sep 2012 06:53:00 -0000 Received: (qmail 17003 invoked by uid 22791); 18 Sep 2012 06:52:58 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 06:52:44 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MAJ007009MI4V00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 18 Sep 2012 09:51:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAJ0076R9QI2ZA0@a-mtaout21.012.net.il>; Tue, 18 Sep 2012 09:51:54 +0300 (IDT) Date: Tue, 18 Sep 2012 06:53:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] traceframe_changed observer and MI notification In-reply-to: <5057BB72.9070305@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83pq5j257w.fsf@gnu.org> References: <1346404195-20864-1-git-send-email-yao@codesourcery.com> <5057BB72.9070305@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00343.txt.bz2 > Date: Tue, 18 Sep 2012 08:08:18 +0800 > From: Yao Qi > CC: Eli Zaretskii > > On 08/31/2012 05:09 PM, Yao Qi wrote: > > gdb/doc: > > > > * observer.texi (GDB Observers): New observer 'traceframe_changed'. > > * gdb.texinfo (GDB/MI Async Records): Mention new MI notification > > '=traceframe-changed'. > > Eli, > Could you review the doc part of this patch? > http://sourceware.org/ml/gdb-patches/2012-08/msg00885.html Sorry about the delay. Here goes: > +@item =traceframe-changed,num=@var{tfnum},tracepoint=@var{tpnum} > +@itemx =traceframe-changed,end > +Reports that the traceframe is changed and its number is @var{tfnum}. I suggest to reword: Reports that the trace frame was changed, and its new number is @var{tfnum}. > +or @value{GDBN} stops examining traceframes and resumes live debugging. This line should be edited to explain the meaning of negative values of tfnum. > +The number of the tracepoint associated with this traceframe is > +@var{tpnum}. ^^^^^^^^^^ "trace frame" > +@deftypefun void traceframe_changed (int @var{tfnum}, int @var{tpnum}) > +The traceframe is changed to @var{tfnum} in command @code{tfind}. ^^^^^^^^^^ "trace frame" Also, I don't understand the significance of the reference to 'tfind'. Why is it important to mention that? > +The number of the tracepoint associated with this traceframe is > +@var{tpnum}. When @var{tfnum} is negative, @value{GDBN} resumes > +live debugging. The last sentence should follow the description of tfnum. I would also rephrase it: If var{tfnum} is negative, it means @value{GDBN} resumes live debugging. Thanks.