From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10509 invoked by alias); 27 Apr 2013 18:55:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10499 invoked by uid 89); 27 Apr 2013 18:55:58 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 27 Apr 2013 18:55:57 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MLX00L00GL33H00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 27 Apr 2013 21:55:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MLX00KA5GL6VU40@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 27 Apr 2013 21:55:54 +0300 (IDT) Date: Mon, 29 Apr 2013 08:38:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Thread exit messages on MS-Windows In-reply-to: <20130427181040.GA7166@calimero.vinschen.de> To: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ppxfst02.fsf@gnu.org> References: <83obd1tyi7.fsf@gnu.org> <838v44tnf8.fsf@gnu.org> <8361z8tkjk.fsf@gnu.org> <20130427181040.GA7166@calimero.vinschen.de> X-SW-Source: 2013-04/txt/msg00849.txt.bz2 > Date: Sat, 27 Apr 2013 20:10:40 +0200 > From: Corinna Vinschen > > On Apr 27 12:00, Eli Zaretskii wrote: > > One minor correction: > > > > > + else if (print_thread_events && id != main_thread_id) > > > + printf_unfiltered (_("[%s exited with code %d]\n"), > > ^^ > > This should be %lu, not %d. > > If this code is generic and runs under Cygwin as well, then please make > that %u, not %lu. DWORD is a 4 byte value and under 64 bit Cygwin > (LP64), it's not the same as long, but as int. Alternatively, add an > explicit cast to unsigned long to the argument. Thanks, will do (the former, probably).