From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70503 invoked by alias); 25 Jul 2015 08:09:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70452 invoked by uid 89); 25 Jul 2015 08:09:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 Jul 2015 08:08:59 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NS100D00AEN2J00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 25 Jul 2015 11:08:52 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS100CKKAMSTM90@a-mtaout20.012.net.il>; Sat, 25 Jul 2015 11:08:52 +0300 (IDT) Date: Sat, 25 Jul 2015 08:09:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command In-reply-to: To: Andreas Schwab Cc: sergiodj@redhat.com, simon.marchi@ericsson.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83pp3g1wx6.fsf@gnu.org> References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com> <838ua52wmp.fsf@gnu.org> <87oaj148e7.fsf@igel.home> <834mks3e5r.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00743.txt.bz2 > From: Andreas Schwab > Cc: sergiodj@redhat.com, simon.marchi@ericsson.com, gdb-patches@sourceware.org > the set of non-shells is finite, because they will match a line in > /etc/shells. I'm okay with looking up non-shells in /etc/shells, but that's not what the proposed patch does. It just compares the shell's file name with a list of known "invalid" shells. It doesn't even mention /etc/shells, in fact, not even in the documentation parts of the patch.