Re: [PATCH 2/5] arc: Set section to ".text" when disassembling

Pedro Alves
2017-02-17T12:31:28Z

On 02/16/2017 04:35 PM, Anton Kolesov wrote:
> Hi Yao,
>
>> info->section should be valid, but why must it be ".text"? Can I
>> info->disassembly
>> instructions in .plt section? How about using find_pc_section (addr) to get
>> the right section? like mep_gdb_print_insn.
>
> Actual section doesn't matter here because opcodes really need elf header, which is
> just obtained through a section. I've used .text simply because it is the section that is
> very likely to exist. Using find_pc_section seems to be a much better solution, I wasn't
> aware of it. Will change this in second version of the patch.

And even better approach would be to include the right arch in
the xml target description, in the (existing) <architecture> element, and
then somehow pass that info down to opcodes here...

Thanks,
Pedro Alves