RE: [PATCH 2/5] arc: Set section to ".text" when disassembling

Anton Kolesov
2017-03-15T15:16:36Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1458 bytes --]

>
> On 02/16/2017 04:35 PM, Anton Kolesov wrote:
> > Hi Yao,
> >
> >> info->section should be valid, but why must it be ".text"? Can I
> >> info->disassembly
> >> instructions in .plt section? How about using find_pc_section (addr)
> >> to get the right section? like mep_gdb_print_insn.
> >
> > Actual section doesn't matter here because opcodes really need elf
> > header, which is just obtained through a section. I've used .text
> > simply because it is the section that is very likely to exist. Using
> > find_pc_section seems to be a much better solution, I wasn't aware of it.
> Will change this in second version of the patch.
>
> And even better approach would be to include the right arch in the xml
> target description, in the (existing) <architecture> element, and then
> somehow pass that info down to opcodes here...

In our BFD ARC EM and ARC HS are treated as same processor (ARC v2) and
differ via flags in private ELF header, so changing BFD arch will not work.
I'd need to change opcodes, so that it will accept processor as an argument,
instead of always reading ELF header. That would take a while, so I will
remove this patch from the series and will resubmit it later, separately
from prologue analysis. The only downside is that several architecture
specific test cases will not pass for ARC HS processor for the time being.

Anton

>
> Thanks,
> Pedro Alves

\x16º&Öéj×!zÊÞ¶êç×~úÓ™b²Ö«r\x18\x1dn–­r\x17¬