From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108675 invoked by alias); 23 Sep 2017 06:00:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108541 invoked by uid 89); 23 Sep 2017 06:00:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1461 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Sep 2017 06:00:23 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvdUD-00074L-Bn for gdb-patches@sourceware.org; Sat, 23 Sep 2017 02:00:22 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvdU8-00071h-L9; Sat, 23 Sep 2017 02:00:16 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1361 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvdU7-0004nE-Vd; Sat, 23 Sep 2017 02:00:16 -0400 Date: Sat, 23 Sep 2017 06:00:00 -0000 Message-Id: <83poaiar9u.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, palves@redhat.com In-reply-to: <87o9q2zcip.fsf@redhat.com> (message from Sergio Durigan Junior on Fri, 22 Sep 2017 16:47:26 -0400) Subject: Re: [PATCH v3 5/5] Extend "set cwd" to work on gdbserver Reply-to: Eli Zaretskii References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-6-sergiodj@redhat.com> <83o9q3cftp.fsf@gnu.org> <87bmm21sig.fsf@redhat.com> <837ewqczzs.fsf@gnu.org> <87o9q2zcip.fsf@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00731.txt.bz2 > From: Sergio Durigan Junior > Cc: gdb-patches@sourceware.org, palves@redhat.com > Date: Fri, 22 Sep 2017 16:47:26 -0400 > > > GDB does know about target-charset and host-charset. I'd expect file > > names that are sent to the target be in the target charset, but since > > what get_inferior_cwd returns is in host charset (it was typed by the > > user), I think a conversion might be in order. > > I don't know. We never seem to do that in other cases. For example, > when we are starting the inferior remotely: > > static int > extended_remote_run (const std::string &args) > { > ... > if (strlen (remote_exec_file) * 2 + len >= get_remote_packet_size ()) > error (_("Remote file name too long for run packet")); > len += 2 * bin2hex ((gdb_byte *) remote_exec_file, rs->buf + len, > strlen (remote_exec_file)); > > > The "remote_exec_file" variable is also something that the user inputs > through the "set remote exec-file" command. It doesn't seem like we > need to worry about charset conversion here. If remote_exec_file came from the target, that's okay, as it would be already in the target charset. But if it is typed by the user, then I guess we indeed have such problems, when the 2 charsets are different. Anyway, I don't want to block the changeset or hijack the discussions. Feel free to go ahead with pushing if we generally ignore this issue elsewhere. Thanks.