Re: [RFC 8.3 0/3] Some style fixes

Tom Tromey
2019-03-11T20:15:44Z

Eli> However, the artifacts I saw in the TUI display in the
Eli> pretest are still there. In particular, the right-hand side of the
Eli> frame of the source window still gets overwritten when stepping
Eli> through the inferior's code, and it looks like the newline is not
Eli> echoed after commands typed in the command window.

I wonder if this is the "nonl" bug.
You can test that theory by applying the appended.

Tom

diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c
index d006e41cabb..b25b55b8515 100644
--- a/gdb/tui/tui-io.c
+++ b/gdb/tui/tui-io.c
@@ -606,15 +606,15 @@ tui_mld_beep (const struct match_list_displayer *displayer)
static int
gdb_wgetch (WINDOW *win)
{
- nonl ();
+ /* nonl (); */
int r = wgetch (win);
- nl ();
+ /* nl (); */
/* In nonl mode, if the user types Enter, it will not be echoed
properly. This will result in gdb output appearing immediately
after the command. So, if we read \r, emit a \r now, after nl
mode has been re-entered, so that the output looks correct. */
- if (r == '\r')
- puts ("\r");
+ /* if (r == '\r') */
+ /* puts ("\r"); */
return r;
}