Re: [RFC 8.3 0/3] Some style fixes

Pedro Franco de Carvalho
2019-03-26T20:52:35Z

Hello,

It seems that issue 1) that Hannes reported is still present, and
affects both master and the release branch. Control characters like
form feed are being printed infinitely in the CLI when listing a source
file (for form feed lots of "^L"s are being printed).

Thanks!
--
Pedro Franco de Carvalho

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Hannes" == Hannes Domani via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> 1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled correctly any more when
> Hannes> list'ing some source code, resulting in an endless loop.
> Hannes> See print_source_lines_base(), I just added "++iter" in the last 2 if() blocks, that fixed it for me.
>
> Hannes> 2) In TUI, scrolling right with the arrow keys, the first keypress doesn't do anything.
> Hannes> (that's just a very minor nuisance)
>
> Hannes> 3) Again in TUI, scrolling right handles TABS and escaped characters as single characters,
> Hannes> which just looks weird.
>
> Thanks, I will take a look at these.
>
> I suspect #2 is the nonl problem. Could you try the patch I sent in
> another branch of this thread?
>
> Tom