From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156251-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 85237 invoked by alias); 22 May 2019 05:01:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 85202 invoked by uid 89); 22 May 2019 05:01:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Maintenance
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 May 2019 05:01:36 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:60001)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hTJNe-0001TR-Eo; Wed, 22 May 2019 01:01:34 -0400
Received: from [176.228.60.248] (port=3775 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hTJNd-0001rK-G8; Wed, 22 May 2019 01:01:33 -0400
Date: Wed, 22 May 2019 05:01:00 -0000
Message-Id: <83pnob84lo.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
CC: gdb-patches@sourceware.org
In-reply-to: <20190518210010.27697-9-tom@tromey.com> (message from Tom Tromey	on Sat, 18 May 2019 15:00:10 -0600)
Subject: Re: [PATCH v2 8/8] Add maint set/show enable-threads
References: <20190518210010.27697-1-tom@tromey.com> <20190518210010.27697-9-tom@tromey.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-05/txt/msg00483.txt.bz2

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Sat, 18 May 2019 15:00:10 -0600
> 
> This adds maint commands to control whether gdb is able to use
> threads.
> 
> gdb/ChangeLog
> 2019-05-18  Tom Tromey  <tom@tromey.com>
> 
> 	* NEWS: Add entry.
> 	* maint.c (_initialize_maint_cmds): Add "enable-threads" maint
> 	commands.
> 
> gdb/doc/ChangeLog
> 2019-05-18  Tom Tromey  <tom@tromey.com>
> 
> 	* gdb.texinfo (Maintenance Commands): Document new maint
> 	commands.

Thanks.

> +maint set enable-threads
> +maint show enable-threads
> +  Control whether GDB can use threads.  The default is "on".

I'd suggest to say what will threads be used for.

> +  add_setshow_boolean_cmd ("enable-threads", class_maintenance,
> +			   &gdb::enable_threads, _("\
> +Set whether gdb can use multiple threads."), _("\
> +Show whether gdb can use multiple threads."), _("\
> +If enabled, gdb will use multiple threads when possible."),

maybe also here.

The documentation parts are OK with this nit fixed.