From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FMxVACd7x2CQSAAAWB0awg (envelope-from ) for ; Mon, 14 Jun 2021 11:52:07 -0400 Received: by simark.ca (Postfix, from userid 112) id ED38E1F163; Mon, 14 Jun 2021 11:52:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 628021E54D for ; Mon, 14 Jun 2021 11:52:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D10E3945C31 for ; Mon, 14 Jun 2021 15:52:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D10E3945C31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623685926; bh=xdDt7Msu14E63GNWZJwoqdwFGmHh017d1+jg6He98Fk=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mRXlRZILfTLFvNwPKa6yGVeVLhKo+80XG+3mDQbSiS7CPsR1kckl8ahzinB6cnYCF 6jFJfvy1iMWSFVMK/93aBghZbifD/i7GRzMIupTdIMLrLbuTnUpxhonpx8sZsxb7Uh K8Tlrc5a0UMht+tkl+b9m6A3sJyzcggfQ6UgIhMg= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 492013860C3E for ; Mon, 14 Jun 2021 15:51:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 492013860C3E Received: from fencepost.gnu.org ([2001:470:142:3::e]:48814) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsosK-0007C6-Ce; Mon, 14 Jun 2021 11:51:45 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4127 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsosK-0002KR-30; Mon, 14 Jun 2021 11:51:44 -0400 Date: Mon, 14 Jun 2021 18:51:43 +0300 Message-Id: <83pmwo5trk.fsf@gnu.org> To: Felix Willgerodt In-Reply-To: <20210614145411.689277-1-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Mon, 14 Jun 2021 16:54:04 +0200) Subject: Re: [PATCH v2 05/12] python: Introduce gdb.RecordAuxiliary class. References: <20210614145411.689277-1-felix.willgerodt@intel.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Mon, 14 Jun 2021 16:54:04 +0200 > From: Felix Willgerodt via Gdb-patches > > Auxiliary instructions are no real instructions and get their own object > class, similar to gaps. gdb.Record.instruction_history is now possibly a > list of gdb.RecordInstruction, gdb.RecordGap or gdb.RecordAuxiliary > objects. > > This patch is in preparation for the new ptwrite feature, which is based on > auxiliary instructions. > > gdb/ChangeLog: > 2021-06-14 Felix Willgerodt > > * py-record-btrace.c (btpy_insn_or_gap_new): Removed. > (btpy_item_new): New function. > (btpy_list_item): Call btpy_item_new instead of recpy_insn_new. > (recpy_bt_replay_position): Call btpy_item_new instead of > btpy_insn_or_gap_new. > (recpy_bt_begin): Call btpy_item_new instead of btpy_insn_or_gap_new. > (recpy_bt_end): Call btpy_item_new instead of btpy_insn_or_gap_new. > * py-record.c (recpy_aux_type): New static object. > (recpy_aux_object): New typedef. > (recpy_aux_new, recpy_aux_number, recpy_aux_data): New function. > (recpy_aux_getset): New static object. > (gdbpy_initialize_record): Initialize gdb.RecordAuxiliary type. > > gdb/doc/ChangeLog: > 2021-06-14 Felix Willgerodt > > * python.texi (gdb.RecordAuxiliary): New documentation. The documentation part is OK, thanks.