From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FX0KM7upY2Tv4AsAWB0awg (envelope-from ) for ; Tue, 16 May 2023 12:05:15 -0400 Received: by simark.ca (Postfix, from userid 112) id C4E4E1E11E; Tue, 16 May 2023 12:05:15 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ypUSpe1S; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 613D71E111 for ; Tue, 16 May 2023 12:05:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7A7D385695F for ; Tue, 16 May 2023 16:05:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E7A7D385695F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684253114; bh=UmZQV1FsrAeeN+2D8/7WPujCn4rrA0ayA+NmshrxCLY=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ypUSpe1S1nsf464D2laeW4lzS4klYt2GmHfLxyrFPptsD5Q8HllT0Mko70Ym/aohN Z2i8S4IbgBeiiB7Jn1mnxB1xsY68gLCKL85Dzfyq9RRdAcXFeAVM+AaLM26DyibTsK vNawBIn/Ppi3t4qGoJhIPsGOpws+dQivYJ/HKRQo= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 41B053858C83; Tue, 16 May 2023 16:04:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41B053858C83 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyxAR-0006EZ-Mk; Tue, 16 May 2023 12:04:51 -0400 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyxAG-00084e-MU; Tue, 16 May 2023 12:04:51 -0400 Date: Tue, 16 May 2023 19:04:48 +0300 Message-Id: <83pm70z2hr.fsf@gnu.org> To: Bruno Larsen Cc: gdb-patches@sourceware.org, gdb@sourceware.org In-Reply-To: <20230516143826.3431583-2-blarsen@redhat.com> (message from Bruno Larsen via Gdb-patches on Tue, 16 May 2023 16:38:27 +0200) Subject: Re: [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS References: <20230516143826.3431583-1-blarsen@redhat.com> <20230516143826.3431583-2-blarsen@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Cc: gdb@sourceware.org, > Bruno Larsen > Date: Tue, 16 May 2023 16:38:27 +0200 > From: Bruno Larsen via Gdb-patches > > + - Tested-by: > + > + Used when a contributor does not want to comment on the quality > + of the code in the patch, but has tested and sees no regressions on their > + hardware. > + > + - Reviewed-by: > + > + Used when a contributor has looked at code and agrees with the changes, > + but either does not have the authority or doesn't feel comfortable > + approving the patch (usually due to unfamiliarity with a certain > + part of the code). Reviewed-by is used by responsible maintainers as well. > + > + - Approved-by: > + > + Used by responsible mainainers or global maintainers when ^^^^^^^^^^ Typo. > + a patch is ready to be upstreamed. Some patches may touch multiple areas > + and require multiple approvals before landing (such as a maintainer only > + approving documentation), it is up to the maintainer giving the approval tag > + to make it clear when that a tag is not sufficient. > + Responsible, Global and Official FSF-appointed maintainers may approve their > + own patches, but it is recommended that they seek external approval before > + doing so. > + I think the above list is incomplete, because there appears to be no "git trailer" (why do we have to call it "git" trailer, btw? will that change if we ever switch to a different VCS?) for the situation where the responsible maintainer does approve some part of the patch, but not all of it (e.g., because the other parts are not in the expertise domain of that maintainer). I thought Reviewed-by is such a trailer, but based on the above I'm beginning to think I was confused.