From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hGzEOgaoiWRBxwMAWB0awg (envelope-from ) for ; Wed, 14 Jun 2023 07:44:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xCnZFuhA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E4AFB1E0BB; Wed, 14 Jun 2023 07:44:06 -0400 (EDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D55431E0AC for ; Wed, 14 Jun 2023 07:44:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D760E3858028 for ; Wed, 14 Jun 2023 11:44:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D760E3858028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686743043; bh=G/EiDzbuaKdonK1k0LC4jPg4w3aKd0DyV9UX/ozvalY=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xCnZFuhA+sM7fNZVRGgrLTpGzZM112vzY3a59sf7qAptuE63FFvbuuGeukKt0ey5f x8P9OolYm5BVtFr15y+C6UoJwIkFK6GAzrMfwFwBxxgqG9oYRMKz2AHSV6VKblrCUe aecohehBdlb20fu918ZyQyRSejhVv3hUuhYAcAEU= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 996103858D1E for ; Wed, 14 Jun 2023 11:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 996103858D1E Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Oub-0005vE-Bx; Wed, 14 Jun 2023 07:43:41 -0400 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Oua-0003uU-Md; Wed, 14 Jun 2023 07:43:41 -0400 Date: Wed, 14 Jun 2023 14:43:59 +0300 Message-Id: <83pm5yuv40.fsf@gnu.org> To: Simon Farre Cc: gdb-patches@sourceware.org, tom@tromey.com In-Reply-To: <20230614103327.30289-1-simon.farre.cx@gmail.com> (message from Simon Farre via Gdb-patches on Wed, 14 Jun 2023 12:33:27 +0200) Subject: Re: [PATCH v1] gdb/dap - dataBreakpointInfo & setDataBreakpoints References: <20230614103327.30289-1-simon.farre.cx@gmail.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Cc: tom@tromey.com, > Simon Farre > Date: Wed, 14 Jun 2023 12:33:27 +0200 > From: Simon Farre via Gdb-patches > > This is v1 of the implementation of these two requests. I didn't (and cannot) review this in a useful way, but my eye caught a few nits: > - if bp.locations: > + if bp.location is not None: > # Just choose the first location, because DAP doesn't allow > # multiple locations. See > # https://github.com/microsoft/debug-adapter-protocol/issues/13 > + # FIXME this does not matter; GDB can translate it's understanding ^^^^ "its" > + # frameId does not have an effect when var ref is not none, ^^^^ "None", capitalized? > + # however, frameId really never has an effect. An issue has been filed: ^^ Two spaces there. > + # We've resolved the "path" for the variable using varrefs. Construct it ^^ And there. > + # Delete wps that are not found in `breakpoints` request ^^^^^^^^^^^^^ Are we okay with MD-style markup? Thanks.