From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id J2JjCDpCEmUBDh0AWB0awg (envelope-from ) for ; Mon, 25 Sep 2023 22:30:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=TkafgkrD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 170381E0C3; Mon, 25 Sep 2023 22:30:18 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 04B9C1E028 for ; Mon, 25 Sep 2023 22:30:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E77D385B524 for ; Tue, 26 Sep 2023 02:30:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E77D385B524 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695695415; bh=DXtJf0SKonab6QURM01SXTNVVFQzC1/om/aDnK8I/7k=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TkafgkrDqFpj2KY0m19fX5V0E1aDJsgQ+ICxaxWh03hJLDRUlTplD7ZiGkL+FPZyq AbBTqOFsdn4tXnTLkExWeMVEkimHrys6mL37VXTsSlzizlsQMwseRMdghJwmv2+zwo uJhMO7qWn2Hvo1yc2Ou8YRmogxyTvPeug8gGD+I0= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 763C83858D35 for ; Tue, 26 Sep 2023 02:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 763C83858D35 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkxpe-0005mA-KF; Mon, 25 Sep 2023 22:29:51 -0400 Date: Tue, 26 Sep 2023 05:29:18 +0300 Message-Id: <83pm251xc1.fsf@gnu.org> To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230925195751.1120801-1-tom@tromey.com> (message from Tom Tromey on Mon, 25 Sep 2023 13:57:51 -0600) Subject: Re: [PATCH v2] Support the NO_COLOR environment variable References: <20230925195751.1120801-1-tom@tromey.com> X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Tom Tromey > Date: Mon, 25 Sep 2023 13:57:51 -0600 > Cc: Tom Tromey > > I ran across this site: > > https://no-color.org/ > > ... which lobbies for tools to recognize the NO_COLOR environment > variable and disable any terminal styling when it is seen. > > This patch implements this for gdb. > > Regression tested on x86-64 Fedora 38. > > Co-Authored-By: Andrew Burgess > --- > gdb/NEWS | 4 ++++ > gdb/doc/gdb.texinfo | 3 +++ > gdb/main.c | 4 ++++ > gdb/testsuite/gdb.base/early-init-file.exp | 4 +--- > gdb/testsuite/gdb.base/readline-ask.exp | 2 ++ > .../gdb.base/style-interp-exec-mi.exp | 5 +---- > gdb/testsuite/gdb.base/style-logging.exp | 5 +---- > gdb/testsuite/gdb.base/style.exp | 11 +++++----- > .../build-id-no-debug-warning.exp | 5 +---- > gdb/testsuite/gdb.debuginfod/crc_mismatch.exp | 5 +---- > gdb/testsuite/gdb.python/py-format-string.exp | 3 +-- > .../gdb.python/py-source-styling.exp | 4 +--- > gdb/testsuite/gdb.python/py-startup-opt.exp | 5 +---- > gdb/testsuite/gdb.rust/rust-style.exp | 5 +---- > gdb/testsuite/gdb.tui/tui-layout.exp | 18 +++++++++------- > gdb/testsuite/lib/gdb.exp | 21 ++++++++++++++++++- > gdb/testsuite/lib/tuiterm.exp | 3 ++- > 17 files changed, 60 insertions(+), 47 deletions(-) Thanks, the documentation parts are okay. Reviewed-By: Eli Zaretskii